Code Monkey home page Code Monkey logo

Comments (6)

KieronWiltshire avatar KieronWiltshire commented on August 21, 2024 1

I solved the issue by creating this middleware and adding it to the "api" group.

<?php

namespace App\Http\Middleware;

use Closure;
use Illuminate\Auth\AuthenticationException;
use Illuminate\Http\Request;
use Illuminate\Auth\Middleware\Authenticate as Middleware;
use Support\Exceptions\Auth\AuthenticationRequiredException;

class EnsureFallbackAuthGuard extends Middleware
{
    /**
     * Handle an incoming request.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  \Closure  $next
     * @return mixed
     *
     * @throws \Illuminate\Auth\AuthenticationException
     */
    public function handle($request, Closure $next, ...$guards)
    {
        $this->authenticate($request, ['api', 'airlock']);

        return $next($request);
    }

    /**
     * Determine if the user is logged in to any of the given guards.
     *
     * @param \Illuminate\Http\Request $request
     * @param array $guards
     * @return void
     */
    protected function authenticate($request, array $guards)
    {
        try {
            parent::authenticate($request, $guards);
        } catch (AuthenticationException $e) {} // catch and do nothing
    }
}

it essentially forces this:
https://github.com/laravel/framework/blob/6.x/src/Illuminate/Auth/Middleware/Authenticate.php#L63

from sanctum.

taylorotwell avatar taylorotwell commented on August 21, 2024

Share your route definition.

from sanctum.

taylorotwell avatar taylorotwell commented on August 21, 2024

Unnecessary. You don’t need this to do what you want to do. It’s already built into Laravel. If you want to share your original route definition go ahead.

from sanctum.

KieronWiltshire avatar KieronWiltshire commented on August 21, 2024

@taylorotwell I don't believe it checks all guards for non-auth routes though right? I'll try show example:

    Route::name('brand.')->prefix('brand')->middleware('auth:api,airlock')->group(function () {
        Route::get('/', 'BrandController@index')->name('index'); // This checks "api" guard but fallsback to "airlock"
    });

    Route::name('user.')->prefix('user')->group(function () {
        Route::get('/', 'UserController@index')->name('index'); // This only checks "api" guard as it's the default guard
    });

from sanctum.

taylorotwell avatar taylorotwell commented on August 21, 2024

If you feel there is broken behavior send a PR with a fix and a test.

from sanctum.

rickshawhobo avatar rickshawhobo commented on August 21, 2024

I have this same problem. A possibly fix is to allow the auth config to take the same guard array. Something like

    'defaults' => [
        'guard' => 'web,api',
        'passwords' => 'users',
    ],

Your workaround isn't too bad @KieronWiltshire

from sanctum.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.