Code Monkey home page Code Monkey logo

Comments (3)

aliakbarazizi avatar aliakbarazizi commented on August 21, 2024

I think its better to leave the config unchanged, either by removing this line and use Lax directly instead of reading from session config or provide a option in sanctum config to disable this behavior

from sanctum.

driesvints avatar driesvints commented on August 21, 2024

Sorry but right now we don't have any plans to change this as this could impact existing apps. If you want, you're free to attempt a PR so we can look at the code involved.

from sanctum.

aliakbarazizi avatar aliakbarazizi commented on August 21, 2024

Sorry but right now we don't have any plans to change this as this could impact existing apps. If you want, you're free to attempt a PR so we can look at the code involved.

I didn't understood why this is exists in first place, should a library mutate project config? I never see something like this before,

If there is no plan isn't better to include it in document, because this is really a big issue. I think it should be in huge warning in document which tell this middleware will mutate your project config file, be aware!

from sanctum.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.