laragear / cachequery Goto Github PK

Please check these requirements

• This feature helps everyone using this package
• It's feasible and maintainable
• It's non breaking
• I issued a PR with the implementation (optional)

Description

Dear Author,

This is a package that shines.

Can you please make it compatible with PHP 7.4 and Laravel 6+?

Code sample

PHP 7.4
DB::table('user')->cache(30,'id_123')->get();

Please check these requirements

• This feature helps everyone using this package
• It's feasible and maintainable
• It's non breaking
• I issued a PR with the implementation (optional)

Description

Would it be possible to add support for optionally using cache tags? So we can do things like:

Article::latest('published_at')->with('drafts')->take(5)->cache(key: 'latest_articles' tag: 'tenant_1')->get();

Cache::tags('tenant_1')->flush();

etc.

Code sample

See above :)

PHP & Platform

8.1.2

Database

No response

Laravel version

10.x

Have you done this?

• I have checked my logs and I'm sure is a bug in this package.
• I can reproduce this bug in isolation (vanilla Laravel install)
• I can suggest a workaround as a Pull Request

Expectation

$this->assertPublishes() should take also the origin file. There is no point of using this method if we can't ensure the origin and destination under a tag.

Description

Above

Reproduction

//

Stack trace & logs

No response

PHP & Platform

8.1.3

Laravel verion

9.17.0

Have you done this?

• I am willing to share my stack trace and logs
• I can reproduce this bug in isolation (vanilla Laravel install)
• I can suggest a workaround as a Pull Request

Expectation

Forget key programmatically with Facade

CacheQuery::forget('offer_details_distinct_quadro');

or

with artisan command thrown exception

Description

Array to string exception

Reproduction

$arrayOption = Model::query()->cache(key: 'offer_details_distinct_quadro', ttl: now()->addHour())->distinct()->pluck('name', 'name')

Stack trace & logs

ErrorException 

  Array to string conversion

  at vendor/laravel/framework/src/Illuminate/Cache/RedisStore.php:223
    219▕      * @return bool
    220▕      */
    221▕     public function forget($key)
    222▕     {
  ➜ 223▕         return (bool) $this->connection()->del($this->prefix.$key);
    224▕     }
    225▕ 
    226▕     /**
    227▕      * Remove all items from the cache.

      +18 vendor frames

Are you a Patreon supporter?

No, don't give priority to this

PHP & Platform

8.0.25, Ubuntu 20.04

Database

PostgreSQL 13

Laravel version

9.37

Have you done this?

• I have checked my logs and I'm sure is a bug in this package.
• I can reproduce this bug in isolation (vanilla Laravel install)
• I can suggest a workaround as a Pull Request

Expectation

The cache scope should also works with paginate()

Description

The paginte() method returns TypeError, but if I change it to simplePaginate method all working fine.

Reproduction

$model = Example::query()->cache()->paginate();

Stack trace & logs

{
 "class": "TypeError",
  "message": "Illuminate\\Database\\Query\\Builder::__construct(): Argument #1 ($connection) must be of type Illuminate\\Database\\ConnectionInterface, Laragear\\CacheQuery\\CacheAwareConnectionProxy given, called in /home/mp/htdocs/backend/vendor/laravel/framework/src/Illuminate/Database/Query/Builder.php on line 3482"
}