laosb / ghos3 Goto Github PK

In recent versions of Ghost, the storage adapter can be used for multiple object classes (video/audio/generic files) as long as it implements the urlToPath function

I've tested it by simply adding this to index.ts and rebuilding.

urlToPath(url) {
    return url;
}

I'm wondering if it's possible to have the blog's hostname in the image URL instead of the S3 endpoint.

From this:
https://s3-us-west-2.amazonaws.com/bucket/image.jpg

To this:
https://our-blog.com/content/images/size/w1200/2023/11/image.jpg

We're interested in this change because we have CloudFlare set up in front of the blog and want CloudFlare to handle the caching.

Additionally, I'm wondering why the image size is not specified when using this adapter, as all the image URLs seem to point to the full-size image.

Hello @laosb , thank you very much for updating this storage integration. Something that's probably "biting" everyone that tries out this library is this line:

cp -r ./node_modules/ghos3 ./content/adapters/storage/s3

That line should be:

cp -r ./node_modules/ghos3/* ./content/adapters/storage/s3

Because otherwise we end up with ./content/adapters/storage/s3/ghos3/index.js and that is what's making the error: but errored during boot with: Unable to find storage adapter s3 in.

This is wrong in the original package as well.

I haven't tested this, but it would be nice that access_key and secret_key were optional and we let the user use IAM roles (or instance profile) to handle the access to S3. This is the recommended practice anyway.

Thoughts?

Thanks for providing an update to this AWS S3 module but i have an issue when trying to use it and only happens when I add the storage section. For my test i added the example supplied

ERROR Unable to find storage adapter s3 in ,/var/lib/ghost/content/adapters/,/var/lib/ghost/versions/5.44.0/core/server/adapters/.