landerlyoung / jenny Goto Github PK

As JFrog announced the deprecation of jcenter (see https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter), please move the artifacts to an other repository.

File https://github.com/LanderlYoung/Jenny/blob/master/cpp/jnihelper.h has a missing cast, clang complains on line 596:
from:
_jvm->AttachCurrentThread(&env, nullptr);
to:
_jvm->AttachCurrentThread(reinterpret_cast<void**>(&env), nullptr);

An import leads to compile errors (method not found) using clang/linux on line 23, I can't verify it on Android.
from:
#include <string>
to
#include <cstring>

Patch:

--- jnihelper.h	2023-11-29 07:55:21
+++ new.h	2023-11-29 07:56:09
@@ -20,7 +20,7 @@
 #include <jni.h>
 #include <cassert>
 #include <memory>
-#include <string>
+#include <cstring>
 
 #ifdef __ANDROID__
 #include <pthread.h>
@@ -593,7 +593,7 @@
       JNIEnv* env;
 
       explicit EnvWrapper(JavaVM* _jvm) : jvm(_jvm), env(nullptr) {
-        _jvm->AttachCurrentThread(&env, nullptr);
+        _jvm->AttachCurrentThread(reinterpret_cast<void**>(&env), nullptr);
         assert(env != nullptr);
       }

Use some library like JavaPoet for java, KotlinPoet for kotlin to generate cpp code, instead of hand-craft them.

Repro: Add multiple @NativeProxyForClasses annotations to a class.
Observed: Now Jenny won't produce any files.
Expected: Jenny should produce multiple files.

My specific use case is for wrapping a C++ library for Java. I am defining a private nested object named Native within each class that contains all of my external functions.

i.e.

class SomeClass {
  @NativeClass
  private object Native {
     external fun doSomething()
  }
}

class AnotherClass {
  @NativeClass
  private object Native {
     external fun doSomethingElse()
  }
}

When running the kaptKotlin task, the JNI code generation fails due to java.lang.reflect.InvocationTargetException (no error message). Running the task with the --info flag shows

error: Jenny failed to process javax.annotation.processing.FilerException Attempt to reopen a file for path $PROJECT_DIR/build/generated/source/kapt/main/jenny/glue/header/Native.h

Because Jenny is generating the JNI file names solely based on the class name annotated with @NativeClass, it does not allow for naming collisions in the case of inner classes or different packages (i.e. com.example.SomeClass vs. com.example.apackage.SomeClass). JNI headers generated using javah or javac -h avoid this by creating headers that include the fully qualified name of the class.