Feature Request

Summary

As of now, the cache key is kinda passed to the filesystem into the filename. To avoid conflicts with system standards and the cache key regex, we should hash the files name before executing CRUD operations.

BC Break Report

Summary

When you define an own cache_dir, the system always tries the default sys_get_temp_dir first, even though you are not using it. If anything is wrong with it (like no write access), you cannot create a FileSystem Adapter at all.

Previous behavior

The sys_get_temp_dir() was only used in case that no other dir was defined.

Current behavior

I've provided the following config for the filesystem:

'name'    => 'filesystem',
'adapter' => 'filesystem',
'options' => [
    'cache_dir' => 'data/cache/',
    'ttl'       => '3600'
],
'plugins' => [
    [
        'name'    => 'exception_handler',
        'options' => [
            'throw_exceptions' => true,
        ],
    ],
    [
        'name' => 'Serializer'
    ]
]

As you can see, the cache_dir is provided in the settings.
However, since the new version, the FileSystemOptions always calls the setCacheDir with the parameter null:
$this->setCacheDir(null); (FileSystemOptions.php:115)

This results in a fallback to sys_get_temp_dir(), which will then be checked and - on my test maschine - was not writable. The Adapter throws and cannot be created then, though right after that, it would overwrite the CacheDir with the correct and working path.

How to reproduce

Define your sys_temp_dir in your php.ini to a non-existing or not-writable path.
Then try to create an adapter with a valid cache_dir configuration.
It will not work and fails with one exception of the method normalizeCacheDirectory

I must admit, that I am not even aware of the functionality of this code. We are detaching a listener from the event handler, which is always null.
So there is absolutely no chance that this code has any impact.

I wonder if this could be removed.

When looking into the previous implementation, this was related to the Filesystem#getTotalSpace method and was to reset an already detected, cached, total space value for a preconfigured directory. Not sure if the detach logic provides anything useful - but this is just for the sake of completeness here. I will create an issue from this comment for further investigation and refactoring.

Originally posted by @boesing in #26 (review)

Feature Request

Summary

Make this laminas/cache Adapter compatible with new php 8.3 release.

Feature Request

Summary

PSR-16 allows "A-Z, a-z, 0-9, , and ." as valid key characters for the cache item name. But the key name pattern of the Filesystem storage is "/^[a-z0-9+-]*$/Di" and therefore doesn't match PSR-16 since "." isn't allowed here. This leads to errors when using the simple cache decorator on libraries such as "browscap/browscap-php" that has a cache item named "browscap.version".

Current behavior

Using the simple cache decorator with a laminas cache storage such as Filesystem throws an Exception when a dot is used inside the cache item name.

Expected behavior

The cache storage should accept key names with a dot since it's specified by PSR-16 and breaks standard compatibility with the simple cache decorator. A valid key pattern for the Filesystem storage could be this one "^[a-z0-9_+-.]*$/Di".

Bug Report

Summary

The metadata is missing filesize even tho it is both documented via constant and adapter documentation.

Current behavior

The metadata provided does not contain filesize.

How to reproduce

Call Filesystem#getMetadata with any key and check return value.

Expected behavior

Filesystem#getMetadata does return the filesize metadata.

To document the adapter options, I have tried to extract the properties of the option class via script.

Here is a first result:

@boesing
The DocBlocks might need to be extended, but would this be a viable solution? Would all options then be included?

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Repository problems

These problems occurred while renovating this repository. View logs.

• WARN: Use matchDepNames instead of matchPackageNames

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• Update dependency laminas/laminas-serializer to v3
• Update dependency phpunit/phpunit to v11
• Lock file maintenance
• Click on this checkbox to rebase all open PRs at once

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

Hello,

I've update to ^2.0 but a got an issue

aminas\EventManager\EventManager::detach(): Argument #1 ($listener) must be of type callable, null given, called in /var/www/vendor/laminas/laminas-cache-storage-adapter-filesystem/src/Filesystem.php on line 115

The $listerne var is null instead of being a callable, see :

(

EventManagerInterface :

https://github.com/laminas/laminas-eventmanager/blob/9e11e32de9eb66451ddaba81d282cccb9bbf245f/src/EventManagerInterface.php#L96-L106

Feature Request

Summary

Benchmarking of specific storage adapters should be part of the related storage adapter.

Feature Request

Summary

@boesing when will PHP 8.3 support be available in this package?

Actually the most packages uses the filesystem Adapter. This is the reason why the most applications are have a hard dependency to this package.

This results into a high prio for this package... Or I am wrong...

Br
Nusphere

Bug Report

Summary

Since v2 release, this adapter does not require laminas-cache.

Current behavior

No real behavior as I don't think that this component is required directly.

How to reproduce

Require this component, static analyzers will directly rage due to missing laminas-cache dependency.

Expected behavior

laminas/laminas-cache is installed as well.

Feature Request

Summary

As decided during the Technical-Steering-Committee Meeting on August 3rd, 2020, Laminas wants to implement vimeo/psalm in all packages.

Implementing psalm is quite easy.

Required

• Create a .psalm.xml.dist in the project root
• Copy and paste the contents from this psalm.xml.dist
• Run $ composer require vimeo/psalm
• Run $ vendor/bin/psalm --set-baseline=psalm-baseline.xml
• Add a composer script static-analysis with the command psalm --shepherd --stats
• Add a new line to script: in .travis.yml: - if [[ $TEST_COVERAGE == 'true' ]]; then composer static-analysis ; fi
• Remove phpstan from the project (phpstan.neon.dist, .travis.yml entry, composer.json require-dev and scripts)

Optional

• Fix as many psalm errors as possible.

Bug Report

Summary

PHP Fatal error:  During inheritance of IteratorAggregate: Uncaught Return type of Adapter::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[ReturnTypeWillChange] attribute should be used to temporarily suppress the notice

Current behavior

Tests are failing.

How to reproduce

Execute tests with PHP 8.1

Expected behavior

Tests are passing.

Feature Request

Summary

I use Laminas\Cache\Storage\Adapter\FileSystem. It creates/accesses cache files from webserver requests (Apache) and from cron jobs. These run under different users which are not in the same group. That leads to an error when writing a file created by the other.
I think it would be nice to be able to specify as which user/group (chown) the cache files should be created.
Can I submit a PR to add this option? Or am I approaching this the wrong way?

Feature Request

Summary

To be prepared for the december release of PHP 8.0, this repository has some additional TODOs to be tested against the new major version.

In order to make this repository compatible, one has to follow these steps:

• Modify composer.json to provide support for PHP 8.0 by adding the constraint ~8.0.0
• Modify composer.json to drop support for PHP less than 7.3
• Modify composer.json to implement phpunit 9.3 which supports PHP 7.3+
• Modify .travis.yml to ignore platform requirements when installing composer dependencies (simply add --ignore-platform-reqs to COMPOSER_ARGS env variable)
• Modify .travis.yml to add PHP 8.0 to the matrix (NOTE: Do not allow failures as PHP 8.0 has a feature freeze since 2020-08-04!)
• Modify source code in case there are incompatibilities with PHP 8.0

Hi! I have such errors:

[04-Jan-2021 21:27:02 Europe/Warsaw] PHP Warning:  unlink(/home/users/default/public_html/PRIVATE/data/cache/laminascache-5a/laminascache--d751713988987e9331980363e24189ce.tag): No such file or directory in /home/users/default/public_html/PRIVATE/vendor/laminas/laminas-cache-storage-adapter-filesystem/src/Filesystem.php on line 412
[05-Jan-2021 13:01:22 Europe/Warsaw] PHP Fatal error:  Uncaught ErrorException: chmod(): No such file or directory in /home/users/default/public_html/PRIVATE/vendor/laminas/laminas-cache-storage-adapter-filesystem/src/Filesystem.php:1638
Stack trace:
#0 [internal function]: Laminas\Stdlib\ErrorHandler::addError(2, 'chmod(): No suc...', '/home/users/def...', 1638, Array)
#1 /home/users/default/public_html/PRIVATE/vendor/laminas/laminas-cache-storage-adapter-filesystem/src/Filesystem.php(1638): chmod('/home/users/def...', 384)
#2 /home/users/default/public_html/PRIVATE/vendor/laminas/laminas-cache-storage-adapter-filesystem/src/Filesystem.php(337): Laminas\Cache\Storage\Adapter\Filesystem->putFileContent('/home/users/def...', 'PicturesTS\nPict...')
#3 /home/users/default/public_html/PRIVATE/module/CoreTS/src/Model/TsCache.php(0): Laminas\Cache\Storage\Adapter\Filesystem->setTags('PicturesTS_Pict...', Array)
#4 /home/users/default/public_html/PRIVATE/module/CoreTS/src/Model/TsBaseModel.php(0): CoreTS\Model\TsCache->saveCache(Object(Propel\Runtime in /home/users/default/public_html/PRIVATE/vendor/laminas/laminas-cache-storage-adapter-filesystem/src/Filesystem.php on line 1641

Probably caused by too fast / multiple cache cleaning.

Does this code:

...should look like this:

if (file_exists($pathname)) {
    unlink($pathname);
}

To prevent code errors like this?