lambdacat / flatbuffers-rs Goto Github PK

It would be great if Vector lookup_by_key() was implemented!
:-)

create_vector() returns a type that can not be used: Offset<Vector<Offsettest::new_request_v2::Pair>>

I can't use it because when I use the generated add_*() method I get:

 //expected `Offset<Vector<Offset<test::new_request_v2::Pair>, &new_request_v2::Pair>>`,
 //found `Offset<Vector<Offset<test::new_request_v2::Pair>>>`

So Vector<> needs to be constructed with T, I. create_vector() needs a different return type?

This is the generated add_*() fn:

pub fn add_x(&mut self, x: fb::Offsetfb::Vector<fb::Offset<Pair, &Pair>>)

I tried to create a new create_vector() but it required lifetimes, and these lifetimes trickled down into problems with Indirect impls etc. so I don't think that's what we want.

Suggestions?
Thanks!

create_vector() returns a type that can not be used:

Offset<Vector<Offset<test::new_request_v2::Pair>>>

I can't use it because when I use the generated add_*() method I get:

 //expected `Offset<Vector<Offset<test::new_request_v2::Pair>, &new_request_v2::Pair>>`,
 //found `Offset<Vector<Offset<test::new_request_v2::Pair>>>`

So Vector<> needs to be constructed with T, I. create_vector() needs a different return type?

This is the generated add_*() fn:

pub fn add_x(&mut self, x: fb::Offsetfb::Vector<fb::Offset<Pair, &Pair>>)

I tried to create a new create_vector() but it required lifetimes, and these lifetimes trickled down into problems with Indirect impls etc. so I don't think that's what we want.

Suggestions?
Thanks!

Ok, just tossing out a couple of ideas wrt lifetimes and safety:

• we should specify lifetimes on things like get_root()
• we should also use pointer casts instead of transmute()

I would prefer not to rely on unbounded lifetimes.
Would anyone object to a patch? Is this project still maintained?

true and false are reversed in the generated code.
I'll submit a pull request shortly.

Edit: Note to others: I had to patch arbitrary-cat's "flatbuffer" rust-gen branch (not the "flatbuffer-rs" git repo).
So when you want to build a flatc that generates Rust code that correctly deals with bool, you'll need to use my "rust-fix-bool" branch:

lambdacat/flatbuffers#4