lambacck / generate_inserts Goto Github PK

If a table has many columns and lengthy column names, the generated select statement can be incomplete due to truncation . This leads to unpredictable errors or potentially invalid results. In my specific case, I was getting the following results:

PRINT 'Inserting values into [tblsaLocationMaster]'
Msg 105, Level 15, State 1, Line 1
Unclosed quotation mark after the character string 'Purchas'.
Msg 102, Level 15, State 1, Line 1
Incorrect syntax near 'Purchas'.
PRINT 'Done'

Debug mode showed the last few characters of the generated select statement were:
+ REPLACE(RTRIM([Purchas

If the truncation occurred in just the right place, the symptom could be that the command succeeds, but some of the columns are not included in the output.

Changing the @Actual_Values variable from varchar(8000) to varchar(max) resolves the problem.

		WHEN @Data_Type IN ('char','varchar','nchar','nvarchar')

->
WHEN @Data_Type IN ('char','varchar','nchar','nvarchar','date')

currently dates generate unquoted which sql server will not convert to date

(could also cast or convert to date but believe it is never required for date)

this is the output i get

Msg 537, Level 16, State 2, Procedure sp_generate_inserts, Line 333 [Batch Start Line 0]
Invalid length parameter passed to the LEFT or SUBSTRING function.
Msg 537, Level 16, State 2, Procedure sp_generate_inserts, Line 334 [Batch Start Line 0]
Invalid length parameter passed to the LEFT or SUBSTRING function.
Msg 50000, Level 16, State 1, Procedure sp_generate_inserts, Line 338 [Batch Start Line 0]
No columns to select. There should at least be one column to generate the output