lakshmikanth2001 / githooks Goto Github PK

This issue would have fit better in a github discussion Q&A, but this repository doesn't have one yet

Hello!

Why did you choose GitHooks.logLevel to default to info rather than debug?

Thanks!

Just installed this extension on Windows using WSL2 and noticed it wasn't loading. I found the output for the extension and saw these errors logged.

[2023-12-21 18:23:02.696] [INFO]: GitHooks extension is now active!
[2023-12-21 18:23:02.960] [INFO]: hooksPathArray [object Promise],[object Promise],[object Promise],[object Promise],[object Promise],[object Promise],[object Promise]
[2023-12-21 18:23:03.750] [ERROR]: Unable to read or locate hooksDirectory failed with following error : 
 Error: No valid git hook directories found
[2023-12-21 18:23:03.751] [ERROR]: Failed to execute shell command: which java. Error: Error: Command failed: which java

[2023-12-21 18:23:03.751] [WARN]: unable to detect java launguage path

Nowhere in the extension overview does it say java is a dependency.

• Current Regex just verifies whether .git and hook both are present in path or not which not an accurate way to tell whether file belongs to ./git/hook this path

"editor/title": [
				{
					"when": "resourcePath =~ /(?=.*\\.git)(?=.*hooks).*/",
					"command": "git-hooks.runCurrentHook",
					"group": "navigation"
				}
			]

Updated this regex to view the runButton only inside .git/hooks directory

• Add Run and Toogle Button for hooks in editor tool bar

Hello,

I am getting this error:

Error running command git-hooks.reloadHooks: command 'git-hooks.reloadHooks' not found. This is likely caused by the extension that contributes git-hooks.reloadHooks.

I mentioned on configuration Git Hooks: Hooks Directory the full path.

Can you please let me know what I can do?

This issue would have fit better in a github discussion Q&A, but this repository doesn't have one yet

Hello!

Why did you choose to feature a GitHooks.hooksDirectory setting rather than to force it to git config core.hooksPath?
Also, do your extension support multiple repositories in a workspace, such as the monorepo use-case?

Thanks!

I have found this extension quite useful.
But I noticed it has now started always updating setting.json for my workspace.
And it is using an absolute path. This isn't good for my projects as they they are shared as part of the team. The settings.json are useful for syncing with other team members. But the absolute path for the git hooks isn't good.
Ideally, it wouldn't always save the default path.
Ideally, it would support the ${workspaceFolder} variable, so at least if it does save. It could then save the path relative to the workspace folder.

Thanks

The hooksDirectory setting is using an absolute path in the workspace settings.json and as this file is normally committed to the repo it will cause a lot of unnecessary changes to this file for teams of devs or if you work across different devices e.g. Mac and Win.

this issue is resolved in 1.2.1 version please upgrade the extension version

When i try to run the pre-commit git hook VS Code seems to not be able to find it . Although i can see it . What could i be missing

As of Git 2.9.0, you can run 'git config [--set] core.hooksPath ' to tell git where the hooks directory is. By setting at the global or system level, it will affect every repo. Thus on my system I have done 'git config --global core.hooksPath $HOME/.githooks'. Now I only have to update one location to maintain my hooks.

Running 'git config [--get] core.hooksPath' will let you see what the value is that will be used (or blank if not set).

However, GitHooks only looks in the local .git/hooks directory. I consider this a bug, since GitHooks is not usable in this situation.

Run Hook button is display in all files in version 0.0.14 which is fixed in 0.0.15 version please take the latest version update

Searching the marketplace for this extension yields no result, be that via the name, or the full identifier.
Even installing the extension via the .vsix file does not actually seem to install it.