laixintao / iredis Goto Github PK

• http://jeremymikkola.com/posts/2019_03_19_rules_for_autocomplete.html

based on common style.

• render function for every command.

https://github.com/joerick/cibuildwheel

• Command validate:
  • IP validate
  • port validate

Redis-py's connection behavior is different from "redis-cli":

• auth on connect
• select on connect
• command callback
• etc...

redis-cli behaivor.

- [ ] hide password(but supply option to show)

• no save to history file
• implement this command

• decode
• mode: strict? ignore...

All command args, double quotes and single quotes need to be striped.

• group color
• command syntax done on footer.
• summary
• time complex

DEBUG [grammar compile time] 0.6472580432891846
DEBUG [timer] Grammer created: 9.5367431640625e-07 from start.
 INFO iredis start, host=127.0.0.1, port=6379, db=0.
DEBUG Using selector: KqueueSelector
DEBUG [timer] First REPL: 0.04548501968383789 from start.
DEBUG REPL waiting for command...

Takes 0.64secnds to compile when startup, painful slow.

Opened an issue for the toolkit. Currently, we have the color issue, others are fine.

prompt-toolkit/python-prompt-toolkit#953

When results too long, use pager.

Add a config to disable this.

Hung-I Wang, [19.08.19 16:53]
b"'\""

Hung-I Wang, [19.08.19 17:33]
[In reply to hooboo]
"".join([("\\" + chr(byte) if chr(byte) == '"' else chr(byte)) if byte < 127 and chr(byte).isprintable() else f"\\x{byte:02x}" for byte in t])

current:

"\'\\""

expect:

"'\\\""

Autocomplete

Single Column complete:

command (group with color) | summary

footer:

• command syntax (group)
• Summary
• time complexity
• version, your server version, compare
• full help link

Consider adding a new command auto-check key's type first, then get its value based on type.

• If the value list too long, only display few of them.
• addition information, length, type, etc.

INSPECT key ?

• strict: prevent key scan like keys *, which will cause redis stop service;
• normal: prevent destructive commands like FLUSHDB, use prompt to ask Do you want to proceed?
• low(or other name?): print "You are in low mode, you can execute any command without prompt check.

https://github.com/prompt-toolkit/python-prompt-toolkit/blob/2970d29936296349feb84aadb4217e1b9d57e2d3/prompt_toolkit/shortcuts/progress_bar/formatters.py#L316

https://github.com/antirez/redis-doc

May need to figure out how to display markdown in terminal.

127.0.0.1:6379> config set requirepass ""
Unknown subcommand or wrong number of arguments for 'set'. Try CONFIG HELP.

expected

Test on all redis-server stable version on circle ci.

https://pypi.org/project/glom/

https://sedimental.org/glom_restructured_data.html

not code.

iredisrc

• mode
• status...

• 127.0.0.1:6379[0]> in red;
• Command name blob

support command line args

https://stackoverflow.com/questions/13746216/enter-doesnt-work-when-interactive-command-is-launched-in-shell

Current prompt_toolkit not support.

• implement part history search(figure out a way to bypass prompt_toolkit limit
• show key usage in help command, like htop

• commands
• syntax
• group
• callbacks

support encoding, decoding.

• keys
• node
• slots...(not covered)