ladeak / jsonmergepatch Goto Github PK

Trying to find something for realisation RFC7396 patch for my solution in .NET6 . Cloned your code to watch if your NuGet is something foe us.
In project ASPNetCoreWebAPI i have got an error
row 26 in Startup.cs

Do i something wrong?

Hi,

Our ASP.NET Core Controller projects are targeting .NET 6, and our DTO types make use of System.DateOnly (which is new to .NET 6)

The source generator produces wrapper properties like so for DateOnly typed properties:

private System.Nullable<LaDeak.JsonMergePatch.Generated.SafeSystem.DateOnlyWrapped> _dateOfBirth;
public System.Nullable<LaDeak.JsonMergePatch.Generated.SafeSystem.DateOnlyWrapped> DateOfBirth
{
    get { return _dateOfBirth; }
    set
    {
	Properties[11] = true;
	_dateOfBirth = value;
    }
}

If I am understanding correctly, I think DateOnly should be detected as a System type and not wrapped. I think that test occurs in GeneratedTypeFilter, here:

public static bool IsGeneratableType(ITypeSymbol typeInfo)
{
    bool generic = false;
    if (typeInfo is INamedTypeSymbol namedTypeInfo)
	generic = namedTypeInfo.IsGenericType;
    return typeInfo.SpecialType == SpecialType.None && !typeInfo.IsAnonymousType && !typeInfo.IsAbstract && !generic && !typeInfo.IsStatic && typeInfo.TypeKind != TypeKind.Enum;
}

The SpecialType enum doesn't contain a value for DateOnly, because the Microsoft.CodeAnalysis project is targeting .NetStandard 2.0, which doesn't include the DateOnly type.

I am not sure there is a nice solution here, but I guess extending that check for new types outside of .NetStandard 2.0 could work?

Let's say we have a DTO set-up like so:

[Patchable]
public class Client
{
    public string? Forename { get; set; }
    public IEnumerable<ClientAddress>? Addresses { get; set; }
}

[Patchable]
public class ClientAddress
{
   public string? Line1 { get; set; }
   public string? City { get; set; }
}

The generated wrapper class code contains this line:

ApplyChanges()

            if (Properties[1])
                input.Addresses = Addresses;

Which results in the following compiler error:

CS0266	Cannot implicitly convert type 'System.Collections.Generic.IEnumerable<LaDeak.JsonMergePatch.Generated.SafeFoo.ClientAddressWrapped>' to 'System.Collections.Generic.IEnumerable<Foo.ClientAddress>'. An explicit conversion exists (are you missing a cast?)

I.e., ClientAddressWrapped is a sub-type of ClientAddress, and therefore a list or IEnumerable of ClientAddressWrapped can be cast to ClientAddress (as the lists contain references/pointers to the reference types on the heap), but only as an explicit cast.