kylemcdonald / bsp Goto Github PK

After pressing the button during drawing, it will stop.

Typically, the plotter will automatically home after this (because the queue has become emptied while drawing).

But if pressed again before homing, the homing operation will be bypassed because the homing operation itself will be cleared from the queue. One way to avoid this is to check if the next operation is homing, and to unset/clear the clear event. A less reliable way would be to clear the clear event immediately after issuing the homing. The operator would have to press the button in the 0.01 second sleep in order to bypass this.

For now I will treat it as a feature: press once, the machine stops and homes. Press twice, it really stops (potentially losing position if it reset).

There was a crash at Cinekid where it looks like the plotter did not report that it was finished drawing, so pressing the button only caused stop() instead of taking a pic and starting a drawing. Unclear what caused this to happen, but maybe some serial commands got lost?

It might be better to initialize the serial connection inside the thread for Plotter. I'm a little surprised it works correctly regardless.