Code Monkey home page Code Monkey logo

explain-xkcd's Issues

new tab has invalid URL if comic URL has query params like use tracking tokens added by Facebook

The .replace(/\D) regex matches all non-digits in the xkcd.com URL and so the resulting explainer URL is invalid like this:

https://xkcd.com/1604/?fbclid=IwZR1Pudsj8KOzNY8m483xQKCD8bNre2Z6jJlyBhN30kZlEHsFfP00cbnQx-o

is replaced with invalid URL

https://www.explainxkcd.com/wiki/index.php/16041884838263000

where "1604" was the expected part and the remainder "1884838263000" are the unexpect digits appended.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.