kvc0 / goodmetrics_kotlin Goto Github PK

Currently the map is <String, Any> but that Any ought to be something like a sealed interface with the supported types.

Need to think about GC impact for wrapper types but probably it'd be fine as-is with a sealed interface.

need to add an API to Metrics that enables it to record histograms separately from bare numbers. Need to think about this api, as it will be shared between the non-aggregated and the locally aggregated pipelines.

jitpack is fine to incubate but maven would be the more enterprisey place to publish to

You can't safely look up a Map.Entry because you can't just instantiate one afaik. Just use a plain old data class for the dimension set membership, maybe call it like typedef MetricPosition = Set<Dimension>

it does not even check if a pr builds