kuninoto / 42_ft_transcendence Goto Github PK

When one of us creates an account on the site an achievement relative to being one of the developers is assigned
(check by intra name upon user creation)

• Need friendship_id on users/{id} so its possible to use /friendship/{friendship_id}/update
• Being able to recive pending requests user on /users/search (send a request to a user won't make it disapear from the query).
• Recive the friendship_status on /users/search

• Merge unfriend and cancel update into one

• Also, when the username query is empty return empty array

Discuss and take in consideration the possibility of adding the option to play vs AI

Add:

• object theme to /me whith background and paddle theme

theme : { background: string, paddle: string, }

• post /me/theme that will receive the theme

The frontend it's just the reflection of backend's logic, this means that the paddle, ball and score aren't connected in anyway they just update when needed

Which mean:

• Both clients emit the paddle position to the bo

• The bo starts the ball position and speed and because it has the paddles can also do the collisions
  So for the frontend that only receives the ball position the collisions are meaningless.

• Every time the ball passes one of the sides (point) an event from bo is emitted with the new scores.
  There is one emit on bo with the paddles and ball position (to reset), then a 2~3 seconds delay w/o emits, and the game starts again.

• score passes the max. Bo emits a winner message with the winner and disconnects both

When I tried to run the app on my side I was not able to login properly with 42's auth and this error popped on the frontend container logs:

frontend  | 
frontend  | Import trace for requested module:
frontend  | ./node_modules/ws/lib/validation.js
frontend  | ./node_modules/ws/lib/receiver.js
frontend  | ./node_modules/ws/wrapper.mjs
frontend  | ./node_modules/engine.io-client/build/esm-debug/transports/websocket-constructor.js
frontend  | ./node_modules/engine.io-client/build/esm-debug/index.js
frontend  | ./node_modules/socket.io-client/build/esm-debug/url.js
frontend  | ./node_modules/socket.io-client/build/esm-debug/index.js
frontend  | ./contexts/GameContext.tsx
frontend  | ./app/matchmaking/finding-opponent/page.tsx
frontend  | - warn ./node_modules/ws/lib/buffer-util.js
frontend  | Module not found: Can't resolve 'bufferutil' in '/app/node_modules/ws/lib'
frontend  | 
frontend  | 
frontend  | Import trace for requested module:
frontend  | ./node_modules/ws/lib/buffer-util.js
frontend  | ./node_modules/ws/lib/receiver.js
frontend  | ./node_modules/ws/wrapper.mjs
frontend  | ./node_modules/engine.io-client/build/esm-debug/transports/websocket-constructor.js
frontend  | ./node_modules/engine.io-client/build/esm-debug/index.js
frontend  | ./node_modules/socket.io-client/build/esm-debug/url.js
frontend  | ./node_modules/socket.io-client/build/esm-debug/index.js
frontend  | ./contexts/GameContext.tsx
frontend  | ./app/matchmaking/finding-opponent/page.tsx
frontend  | 
frontend  | 
frontend  | ./node_modules/ws/lib/validation.js
frontend  | Module not found: Can't resolve 'utf-8-validate' in '/app/node_modules/ws/lib'
frontend  | 
frontend  | 
frontend  | Import trace for requested module:
frontend  | ./node_modules/ws/lib/validation.js
frontend  | ./node_modules/ws/lib/receiver.js
frontend  | ./node_modules/ws/wrapper.mjs
frontend  | ./node_modules/engine.io-client/build/esm-debug/transports/websocket-constructor.js
frontend  | ./node_modules/engine.io-client/build/esm-debug/index.js
frontend  | ./node_modules/socket.io-client/build/esm-debug/url.js
frontend  | ./node_modules/socket.io-client/build/esm-debug/index.js
frontend  | ./contexts/GameContext.tsx
frontend  | ./app/matchmaking/finding-opponent/page.tsx
frontend  | - error api/api.ts (14:29) @ localStorage
frontend  | - error ReferenceError: localStorage is not defined
frontend  |     at eval (./api/api.ts:18:36)
frontend  |     at (sc_client)/./api/api.ts (/app/.next/server/app/auth/page.js:710:1)
frontend  |     at __webpack_require__ (/app/.next/server/webpack-runtime.js:33:43)
frontend  |     at eval (./contexts/AuthContext.tsx:9:66)
frontend  |     at (sc_client)/./contexts/AuthContext.tsx (/app/.next/server/app/auth/page.js:754:1)
frontend  |     at __webpack_require__ (/app/.next/server/webpack-runtime.js:33:43)
frontend  |     at eval (./app/layout.tsx:9:79)
frontend  |     at (sc_client)/./app/layout.tsx (/app/.next/server/app/auth/page.js:743:1)
frontend  |     at __webpack_require__ (/app/.next/server/webpack-runtime.js:33:43)
frontend  |   12 |      headers: {
frontend  |   13 |              'Content-Type': 'multipart/form-data',
frontend  | > 14 |              'Authorization': `Bearer ${localStorage.getItem('pong.token')}`
frontend  |      |                                        ^
frontend  |   15 |      },
frontend  |   16 | })
frontend  |   17 | 

Also, we should check for a scenario where the browser history has the 42 authentication saved (so that allows the user to bypass the 42's login credentials) but the 42's session has expired or if the user is in AGU (he can type his credentials and trigger the 42's auth but most probably a 401 is also returned)

Seems like the Socket user is always the id 1. But it might be due to me directly editing stuff on the DB. Need another account to verify that

To implement: route (?) to request user's info using username approximation (regex ?)

Everything to change darling

• Create endpoint for friend_requests from /me to /me/friend_requests

• Create endpoint for friends from /me to /me/friends

• Remove friendship_* from every /friendship name (eg. friendship_name -> name)
  My code : friend.friend_name

• Send friendship information in /users/{id} and block status

• Automatically reject friend request when blocked

• Remove blocked, friends, (not on pending requests) and self from /users/search

Using the chat socket the backend sends events acknowledgeding that a new achievement was unlocked and the frontend shows a popup with which achievement and its description.

with nginx (?)

• When blocking a request still leaves on pending.

• When request is declined and you can't search for the declined users and if the declined try to send request again doesn't appear on friends requests.

Basically "declined" status is behaving like blocked. W/o the "not be able to search" part, "declined" can be change to "blocked", block table can disappear, and on decline just erase the relation from db.

Add some type of abort system to a situation where 2 users are assigned one room as for the matchmaking but one of them leaves

Upon user (player) connection to game-gateway, enqueue and if there are more than 2 players waiting dequeue both and create a Room for them

OR

Upon user connection to game-gateway create and assign a room for him and later, when a new player arrives, add him to that room

Add some type of player readiness to assert that both players are ready to start the game