Code Monkey home page Code Monkey logo

Comments (5)

KarstenB avatar KarstenB commented on June 7, 2024 1

My guess is that this line here is wrong and should simply be "v1". instead of version https://github.com/kubevirt/kubevirt/blame/e53b1249f073ffab068037973a914303082925c9/pkg/virt-api/api.go#L584C5-L584C37

from kube.

KarstenB avatar KarstenB commented on June 7, 2024 1

Happened to me too with the location comment :D

Anyhow, I initially thought that simply having Kubevirt and using Kube.rs was enough to cause this bug. But as it is only when using Dynamic discovery and it looks like a sincere oversight on KubeVirt side (vs a v1alpha3 being used in the past), I think this bug could be closed without any further action.

from kube.

clux avatar clux commented on June 7, 2024

IIRC from the kubevirt thread i think possibly kubevirt was confusing the version for the apiresource kind with the version of their own apigroup.

If true, then that is probably something that needs to be raised with them. Kind of surprised this works at all on the golang side.

from kube.

KarstenB avatar KarstenB commented on June 7, 2024

Unfortunately I don't seem to have access to the discord thread you mentioned. But a simple mistake seems the most plausible. I also raised it with them kubevirt/kubevirt#10899.

from kube.

clux avatar clux commented on June 7, 2024

That looks like a good change upstream to me. Thanks for digging into this.

discord info

The tokio discord thread is mostly just someone drive-by noticing the dynamic_watcher example did not work with kubevirt during discovery and giving a serialization error:

  }, Error("invalid value: string \"v1alpha3\", expected v1", line: 3, column: 25)
  Error: Error deserializing response

  Caused by:
      invalid value: string "v1alpha3", expected v1 at line 3 column 25

and doing some cross-referencing with kubectl -v9 without it being too fruitful.

EDIT: accidentally replied this to upstream repo 🤦

from kube.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.