Comments (7)
That's a good point, thank you. I'll bump the entry for it.
from kube.
try upgrading chrono first, we did do some stuff with chrono to avoid new lint warnings
from kube.
How can I upgrade chrono if it's being pulled automatically by both crates?
from kube.
I assume you have a pin for it in your lock file. The chrono::TimeDelta
struct does exist in the last version.
from kube.
so I think what happens here is that chrono::TimeDelta
was missing in chrono 0.4.33 (a semver compatible version) and added in 0.4.34. So when you upgrade kube/k8s-openapi cargo doesn't force you to also upgrade chrono because chrono have not indicated they have added anything by making a semver-minor (and we accidentally started relying on a new feature without knowing it was a new feature).
If you run cargo update chrono
it will fix the issue and bump the pin in your lockfile (without needing an explicit dependency on chrono in your Cargo.toml
).
from kube.
Thank you, completely forgot about the lockfile
from kube.
kube-client
specifies,
chrono = { version = "0.4.32", default-features = false }
As @clux says above, TimeDelta
isn't added until 0.4.34.
kube-client
could just depend on 0.4.34
— it isn't compatible with 0.4.32, so specifying that as a version doesn't make much practical sense as it'll never work, and if you specify 0.4.34
then cargo
will just do the right thing & realize the locked version will never work. I.e., you should never need to remember the lockfile.
It'd be nice if kube-rs
would just consider this a bug, to avoid all downstream users from having to manually handle this.
(chrono
here is pre-1.0, so backwards-compatible versions — i.e., adding a feature — wouldn't bump the minor. Cargo's consideration of 0.x.y versions is slightly different than the SemVer.org spec.)
from kube.
Related Issues (20)
- More ergonomic ListParams::labels HOT 2
- Reflector should not request the whole meta HOT 8
- Add method to WatchStreamExt to get object that event type is deleted HOT 1
- Using customized Kubeconfig struct not working as per documentation HOT 2
- Websocket upgrade error messages are discarded
- Allow resourceVersion to be specified when creating a watcher HOT 1
- Access Kubelet exec/logs/portforward endpoints HOT 8
- Make it easier to get an `Api` for a `DynamicObject` HOT 4
- missing field `certificate-authority-data` when exec credential plugins
- Release Note Sketch for 0.89.0 HOT 2
- kube::client::Body::empty() is private and cannot be used in unit tests HOT 3
- upgrade `rustls` to 0.23 and `hyper-rustls` 0.27
- release plan for 0.90 HOT 1
- Can List support sorting? HOT 2
- Improve shared streams interfaces
- Change Controller concurrency defaults based on available CPU
- Why is the schema of the api server url fixed to HTTPS,can it support configurable features? HOT 6
- Expose scheduler metrics from runtime
- Breaking api changes between minor versions of json-patch dependency HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kube.