Code Monkey home page Code Monkey logo

Comments (7)

clux avatar clux commented on June 7, 2024 1

That's a good point, thank you. I'll bump the entry for it.

from kube.

clux avatar clux commented on June 7, 2024

try upgrading chrono first, we did do some stuff with chrono to avoid new lint warnings

from kube.

DMaxter avatar DMaxter commented on June 7, 2024

How can I upgrade chrono if it's being pulled automatically by both crates?

from kube.

clux avatar clux commented on June 7, 2024

I assume you have a pin for it in your lock file. The chrono::TimeDelta struct does exist in the last version.

from kube.

clux avatar clux commented on June 7, 2024

so I think what happens here is that chrono::TimeDelta was missing in chrono 0.4.33 (a semver compatible version) and added in 0.4.34. So when you upgrade kube/k8s-openapi cargo doesn't force you to also upgrade chrono because chrono have not indicated they have added anything by making a semver-minor (and we accidentally started relying on a new feature without knowing it was a new feature).

If you run cargo update chrono it will fix the issue and bump the pin in your lockfile (without needing an explicit dependency on chrono in your Cargo.toml).

from kube.

DMaxter avatar DMaxter commented on June 7, 2024

Thank you, completely forgot about the lockfile

from kube.

roy-work avatar roy-work commented on June 7, 2024

kube-client specifies,

chrono = { version = "0.4.32", default-features = false }

As @clux says above, TimeDelta isn't added until 0.4.34.

kube-client could just depend on 0.4.34 — it isn't compatible with 0.4.32, so specifying that as a version doesn't make much practical sense as it'll never work, and if you specify 0.4.34 then cargo will just do the right thing & realize the locked version will never work. I.e., you should never need to remember the lockfile.

It'd be nice if kube-rs would just consider this a bug, to avoid all downstream users from having to manually handle this.

(chrono here is pre-1.0, so backwards-compatible versions — i.e., adding a feature — wouldn't bump the minor. Cargo's consideration of 0.x.y versions is slightly different than the SemVer.org spec.)

from kube.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.