ksundberg / coursematerials Goto Github PK

View Code? Open in Web Editor NEW

7.0 7.0 64.0 2.08 MB

Course materials for various computer science courses

License: MIT License

TeX 13.10% XSLT 2.81% Makefile 0.44% C++ 77.46% CMake 0.76% Prolog 5.22% Yacc 0.15% Lex 0.07%

coursematerials's People

Contributors

Stargazers

Watchers

Forkers

tjonesy sobray11 nick-benoit14 efair4 codystevens benjamincall ammonhepworth sailanarmo rachelrob248 holmanjr jakeyeagley32 tricyclelad justin-t-wood jazames lynnbridge bhandley24 davidbrowning aaronmorgenegg gitcameron 2ndchance austinadams104 josephsundberg pianomanfrazier haleynwheeler troenoel mandibarton aderbique ksanman notadamking obstructor divadev j-piland chancelish daniel-gohier kellyab christopher42 crlsktr higgsch craig653 likestrains mattofthekidd padent palexander21 aaronlafitte rmedlyn garryjable rick-bob rachelmikulecky philipnelson5 programmicon nobueitoh technaturalist kuzco1776 mattb1888 davidnielsen94 spencerballing jarencampbell solyanaa link270 rhysdav jacstrong nvsneddon aposhiana gavinfowler mckayransom

coursematerials's Issues

Task Completion time never set

The tasks never get their completion time set when they finish so you cant calculate the latencies.

[cs3100] jobDone Events are never processed

Events that execute jobDone() are pushed to the queue but never have their process() called.

dev goes out of bounds on devices

In Simulation.cpp this line appears twice: auto dev = jobs[job].tasks[jobs[job].cur].device; followed by some form of devices[dev]. When stepping though however, dev is sometimes outside the bounds of devices.

Job: 3 dev: 2 size: 2
Job: 3 dev: 2 size: 2
Job: 4 dev: 2 size: 2
Job: 6 dev: 2 size: 2
Job: 3 dev: 2 size: 2
Job: 3 dev: 2 size: 2
Job: 4 dev: 2 size: 2
Job: 1 dev: 2 size: 2
Job: 9 dev: 2 size: 2
Job: 9 dev: 2 size: 2

Device not initialized

It appears that the FifoReadyQueue for each device may not actually be initialized. I am getting a segfault when a job is pushed onto a device queue. From the debugger it looks like the queue is pointing at garbage memory.

queue {Cannot access memory at address 0x40d5fbde00000000

#0  0x000000000041ddb9 in __gnu_cxx::new_allocator<int>::construct<int, int const&> (this=0x6483f0, __p=0xbf800000) at /usr/include/c++/5/ext/new_allocator.h:120
#1  0x000000000041dbe1 in std::allocator_traits<std::allocator<int> >::construct<int, int const&> (__a=..., __p=0xbf800000) at /usr/include/c++/5/bits/alloc_traits.h:530
#2  0x000000000041da96 in std::deque<int, std::allocator<int> >::push_back (this=0x6483f0, __x=@0x7fffffffda64: 2) at /usr/include/c++/5/bits/stl_deque.h:1521
#3  0x000000000041d9ff in std::queue<int, std::deque<int, std::allocator<int> > >::push (this=0x6483f0, __x=@0x7fffffffda64: 2) at /usr/include/c++/5/bits/stl_queue.h:216
#4  0x000000000041d94c in cs3100::FifoReadyQueue::add (this=0x6483e8, x=2) at /home/taylor/OneDrive/Documents/Classes/CS3100/Projects/scheduler/FifoReadyQueue.cpp:5
#5  0x00000000004204aa in cs3100::Simulation::scheduleIo (this=0x648ba0, job=2) at /home/taylor/OneDrive/Documents/Classes/CS3100/Projects/scheduler/Simulation.cpp:57
#6  0x000000000042088b in cs3100::Simulation::jobDone (this=0x648ba0, job=2, time=4.34699965) at /home/taylor/OneDrive/Documents/Classes/CS3100/Projects/scheduler/Simulation.cpp:85
#7  0x0000000000420011 in cs3100::Simulation::<lambda()>::operator()(void) const (__closure=0x649180) at /home/taylor/OneDrive/Documents/Classes/CS3100/Projects/scheduler/Simulation.cpp:48
#8  0x00000000004217c3 in std::_Function_handler<void(), cs3100::Simulation::scheduleJob()::<lambda()> >::_M_invoke(const std::_Any_data &) (__functor=...) at /usr/include/c++/5/functional:1871
#9  0x0000000000422718 in std::function<void ()>::operator()() const (this=0x649180) at /usr/include/c++/5/functional:2267
#10 0x0000000000420c50 in cs3100::Simulation::run (this=0x648ba0) at /home/taylor/OneDrive/Documents/Classes/CS3100/Projects/scheduler/Simulation.cpp:129
#11 0x0000000000427159 in main () at /home/taylor/OneDrive/Documents/Classes/CS3100/Projects/scheduler/scheduler_main.cpp:77#0  0x000000000041ddb9 in __gnu_cxx::new_allocator<int>::construct<int, int const&> (this=0x6483f0, __p=0xbf800000) at /usr/include/c++/5/ext/new_allocator.h:120

Priority Queue backwards

Events are run from greatest time to lowest time. The priority needs reversed so they go lowest to highest.

Issue if inital task is IO

The simulator will always put the first task on the cpu whether it is a cpu task or io task.

Task incrementation issues

It appears that on the 3rd or so task of a job incrementing fails. The next task it pulls up tends to be either the same task or a the first task of the job, or just a garbage task that makes no sense.

Doesn't work for large job numbers

Segfaults or has memory corruption randomly. Increases with higher numbers of jobs.

Devices not created

devices are never created so when an IO job is scheduled there is a segfault.

[cs3100] There's at least four sources of segmentation faults

Extra Job Schedule (Working simulation code attatched)

I was able to work around or fix every bug except for there is an odd edge case where a single job is scheduled an extra time. This happens every time the simulator is run but only happens once per run. I cannot figure out where it is getting scheduled.
I worked around that by ignoring ioDone and jobDone for tasks that are already finished. My fixed version of the simulator is attatched. scheduler.tar.gz

More SegFaults

I appear to randomly be getting segfaults when pushing items onto FifoReadyQueues whether it is a device queue or the event queue.