It saved me a lot of time with Mail::Message conversion to MandrillDm::Message, especially as mail gem doesn't have consistent/intuitive public API for simple things like mail.from and mail.to.
Much appreciate with your work and will definitely contribute if I find something useful 👍

merge_vars and global_merge_vars will allow to send customized messages to each recipient.

The ability to use Mandrill templates is excellent, but the Readme example seems to be a bit off-- specifically this bit:

template_content: [ # optional
    {
      name: 'header',
      content: 'string to replace a *|header|* in your template',
    },
    {
      name: 'content',
      content: 'string to replace a *|content|* in your template'
    }
  ]
)

The template_content key is used by editable content areas, which insert content into tags with an associated mc:edit property, while *|variable|* syntax is for merge variables, which can be specified either with the global_merge_vars key (for all recipients) or the merge_vars key (per recipient).

Maybe you'll transfer this repo to me? I'll continue support and merge pull requests.

I was surprised, that MandrillDm::Message doesn't have #bcc method. After digging some code I noticed, that we accumulate to, cc and bcc inside #combine_address_fields and handle BCC this way. But I can't understand, what is the difference between classic bcc field and custom Mandrillbcc_address parameter?
Example:

class AlphabetMailer < ActionMailer::Base
  def a
    mail(from: '[email protected]',
         to: '[email protected]',
         bcc: '[email protected]',
         subject: 'Alpha',
         body: '',
         delivery_method: :mandrill)
  end

  def b
    mail(from: '[email protected]',
         to: '[email protected]',
         bcc_address: '[email protected]',
         subject: 'Beta',
         body: '',
         delivery_method: :mandrill)
  end
end

# AlphabetMailer.a.deliver_now and AlphabetMailer.b.deliver_now work the same as expected.

NoMethodError: undefined method `error' for nil:NilClass
/bundle/gems/mandrill_dm-1.3.10/lib/mandrill_dm.rb:20:in `configure'

I'm not using rails

Hello,

my code looks like this:

class RemindersMailer < ActionMailer::Base
  def feedback_email
    mail(
      to: '[email protected]',
      body: '',
      subject: 'Your feedback is important to us!',
      template: 'your-feedback-is-important-to-us',
      global_merge_vars: [
          {
              'name' => 'FNAME',
              'content' => 'Jamie'
          },
          {
              'name' => 'CONSULTANT_NAME',
              'content' => 'Grace'
          }
      ]
    )
  end
end

RemindersMailer.feedback_email.deliver_now

But "global_merge_vars" are in header instead in message. So vars aren't replaced. Could you help me? Request looks like this:

    "template_name": "your-feedback-is-important-to-us",
    "template_content": null,
    "message": {
        "auto_html": null,
        "auto_text": null,
        "bcc_address": null,
        "from_email": "[email protected]",
        "from_name": null,
        "global_merge_vars": null,
        "headers": {
            "Date": "Mon, 18 Dec 2017 17:32:32 +0100",
            "From": "[email protected]",
            "To": [
                "[email protected]"
            ],
            "Bcc": "[email protected]",
            "Message-ID": "<[email protected]>",
            "Subject": "Your feedback is important to us!",
            "Mime-Version": "1.0",
            "Content-Type": "text/plain",
            "Content-Transfer-Encoding": "7bit",
            "template": "your-feedback-is-important-to-us",
            "global-merge-vars": "{\"name\"=>\"FNAME\", \"content\"=>\"Jamie\"}, {\"name\"=>\"CONSULTANT_NAME\", \"content\"=>\"Grace\"}"
        },
        "html": null,
        "important": false,
        "inline_css": null,
        "merge": null,
        "merge_language": null,
        "merge_vars": null,
        "metadata": null,
        "preserve_recipients": null,
        "return_path_domain": null,
        "signing_domain": null,
        "subaccount": null,
        "subject": "Your feedback is important to us!",
        "tags": {},
        "text": "",
        "to": [
            {
                "email": "[email protected]",
                "name": null,
                "type": "to"
            },
            {
                "email": "[email protected]",
                "name": null,
                "type": "bcc"
            }
        ],
        "track_clicks": null,
        "track_opens": null,
        "tracking_domain": null,
        "url_strip_qs": null,
        "view_content_link": null
    },
    "async": false,
    "ip_pool": null,
    "send_at": null,
    "key": "xyz"
}

mandrill_dm 1.3.4
rails 5.1.4
mail 2.7.0
mandrill-api 1.0.53

Maybe I'm using it in wrong way? Could you help me?

Can we please get a new release with the latest ip_pool feature ?

Hi,

sorry it took some time to figure out what was the real issue what I mentioned. At last I caught it when I tested this new things under our webpage. I didn't realise it when I downloaded the new codebase that the mail gem was updated and that's why I couldn't see the issue anymore. So here is some debugging:

mail 2.5.4

Run options: include {:locations=>{"./spec/mandrill_dm/message_spec.rb"=>[120]}}
>>>>>>>>>>>>>>mail: #<Mail::Message:70360916361720, Multipart: false, Headers: <global-merge-vars: {"name"=>"TESTVAR", "content"=>"testcontent"}, {"name"=>"TESTVAR2", "content"=>"testcontent2"}>>
>>>>>>>>>>>>>>mail[field]: #<Mail::Field:0x007ffc5a1987b0 @field=#<Mail::OptionalField:0x007ffc5a15a438 @errors=[], @charset=#<Encoding:UTF-8>, @name="global-merge-vars", @length=nil, @tree=nil, @element=nil, @value="{\"name\"=>\"TESTVAR\", \"content\"=>\"testcontent\"}, {\"name\"=>\"TESTVAR2\", \"content\"=>\"testcontent2\"}">>
>>>>>>>>>>>>>>mail[field].instance_variable_get('@value'): nil
F

Failures:

  1) MandrillDm::Message#global_merge_vars takes an array of multiple global_merge_vars
     Failure/Error: expect(message.global_merge_vars).to eq(global_merge_vars)

       expected: [{"name"=>"TESTVAR", "content"=>"testcontent"}, {"name"=>"TESTVAR2", "content"=>"testcontent2"}]
            got: nil

       (compared using ==)
     # ./spec/mandrill_dm/message_spec.rb:127:in `block (3 levels) in <top (required)>'

Finished in 0.01995 seconds (files took 0.32437 seconds to load)
1 example, 1 failure

mail 2.6.3

Run options: include {:locations=>{"./spec/mandrill_dm/message_spec.rb"=>[120]}}
>>>>>>>>>>>>>>mail: #<Mail::Message:70212615828160, Multipart: false, Headers: <global-merge-vars: {"name"=>"TESTVAR", "content"=>"testcontent"}, {"name"=>"TESTVAR2", "content"=>"testcontent2"}>>
>>>>>>>>>>>>>>mail[field]: #<Mail::Field 0x7fb74c0dfdf8 @name="global-merge-vars" @value=[{"name"=>"TESTVAR", "content"=>"testcontent"}, {"name"=>"TESTVAR2", "content"=>"testcontent2"}] @raw_value=nil @charset=nil @field=#<Mail::OptionalField:0x007fb74c0de6d8 @errors=[], @charset=#<Encoding:UTF-8>, @name="global-merge-vars", @length=nil, @tree=nil, @element=nil, @value="{\"name\"=>\"TESTVAR\", \"content\"=>\"testcontent\"}, {\"name\"=>\"TESTVAR2\", \"content\"=>\"testcontent2\"}">>
>>>>>>>>>>>>>>mail[field].instance_variable_get('@value'): [{"name"=>"TESTVAR", "content"=>"testcontent"}, {"name"=>"TESTVAR2", "content"=>"testcontent2"}]
.

Finished in 0.00257 seconds (files took 0.24934 seconds to load)
1 example, 0 failures

So on mail 2.5.4 the [] is missing from the @vaule what is cause the problem. Or actually here the value just a json like version, but on the new mail you get the normal value and a json like one as well.

The real problem is that the actionmailer still using mail 2.5 (Rails 4.2.5 >> mail >= 2.5.4, ~> 2.5). So this issue is affected in all Rails version!

I ran into an issue when sending emails generated from HTML-only templates (they are being delivered as plain text) and tracked it back to this commit:

2a80783

I will try to make a PR to fix this in coming days.

I have a template in Mandrill that I want to use as a replacement for template from Devise. I created a 'UserMailer' and set mandrill_dm gem.

MandrillDm.configure do |config|
  config.api_key = ENV['MANDRILL_API_KEY']
end

  config.action_mailer.perform_deliveries = true
  config.action_mailer.delivery_method = :mandrill

class UserMailer < Devise::Mailer   # or ActionMailer::Base, still doesn't work
  helper :application
  include Devise::Controllers::UrlHelpers

  def reset_password_instructions(user, token, options = {})
    mail(
      to: user.email,
      from: "no-reply@#{ENV['SMTP_DOMAIN']}",
      template: 'reset-password-message',
      merge_language: 'mailchimp',
      global_merge_vars: [
        {
          name: 'reset_password_url',
          content: edit_password_url(user, reset_password_token: token)
        }
      ]
      # or per rcpt merge_vars: [ rcpt: "", vars: [{name:'',content:''},{name:'',content:''}]]
    )
  end
end

Devise.setup do |config|
    config.mailer = 'UserMailer'
end

I have a template published in Mandrill: 'reset-password-message'

I get this error message:

An ActionView::MissingTemplate occurred in passwords#create:

  Missing template user_mailer/reset_password_instructions with "mailer". Searched in:
  * "user_mailer"

I obviously don't have this template in my app, the whole point is to use template in Mandrill.

I'm a bit lost about where to report this. It's only happening if using Rails ActionMailer with an email that includes commas.

This is how to simulate the error:

MandrillDm::Message.new(Mail::Message.new(to: "Juan Monigote, Pepe <[email protected]>")).send :combine_address_fields
=> NoMethodError: undefined method `formatted' for #<Mail::UnstructuredField:0x007facda5daa50>

MandrillDm::Message.new(Mail::Message.new(to: "Juan, Pepe <[email protected]>")).send :combine_address_fields
=> ...Works

It happens if you do this:

class ApplicationMailer < ActionMailer::Base
  def generic_mail(email)
    mail(
      to: "Juan Monigote, Pepe <[email protected]>",
      subject: "test"
    )
  end

The value from to comes from an string. I'm replying to a received email, so the email in fact arrives with a ,.

It would be awesome to extend #2 so that attachments.inline work.

@kshnurov any concern about dropping ruby 2.0 support? It was EOL'd in early 2016.

We may also consider dropping ruby 2.1 since rails 5.0+ requires ruby 2.2+.

Thoughts?

Guys, what do you think if we add logging system to this library? Sometimes it's worth to now what's going on at low level interaction with Mandrill API. Unfortunately, the api-mandrill gem itself doesn't have ability to log it's work. I know that's not very appropriate abstraction level to do such things in mandrill_dm, but maybe we could at least log api call parameters and concise result.
If you find this idea reasonable, let's proceed the discussion.
Also I'm happy to contribute, but I'd like to be referred to good example of logging in other libraries.

@kshnurov Thanks for handling this last PR. I've been very busy. I released 1.3.6 on rubygems. I can add you to rubygems as an owner so you can also cut releases. Looks you should create a rubygems login, then let me know the email address for your login: http://help.rubygems.org/discussions/questions/151-adding-another-owner

According to https://github.com/spovich/mandrill_dm/blob/master/lib/mandrill_dm/message.rb#L60 and https://github.com/spovich/mandrill_dm/blob/master/lib/mandrill_dm/message.rb#L219 this lib strips any headers not in this list, and my custom headers I put on mail[:headers] doesn't arrive to mandrill

How does the async = true config work? Is it supposed to batch the new message POSTs to Mandrill?