Code Monkey home page Code Monkey logo

lstm-footballmatchwinner's People

Contributors

krishnakartik1 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

lstm-footballmatchwinner's Issues

Library versions

Hi, I'm currently looking into this project and it would be very nice to be able to play around with it. However, this isn't going so well since I don't know which versions of the libraries were used during the project. Could you provide me with this information?

Dropped seasons in "dataCleaning"

There is something i do not quite understand. When you append last standings, you actually assign to "playing_statistics_4" and all others below "playing_statistics_3".
Shouldnt it be 3 to 3, 4 to 4, etc. ?

playing_statistics_1 = get_last(playing_statistics_1, Standings, 0)

playing_statistics_2 = get_last(playing_statistics_2, Standings, "15")
playing_statistics_3 = get_last(playing_statistics_3, Standings, "14")
playing_statistics_4 = get_last(playing_statistics_3, Standings, "13")
playing_statistics_5 = get_last(playing_statistics_3, Standings, "12")
playing_statistics_6 = get_last(playing_statistics_3, Standings, "11")
playing_statistics_7 = get_last(playing_statistics_3, Standings, "10")
playing_statistics_8 = get_last(playing_statistics_3, Standings, "9")

Incorrect approach in the new LSTM notebook

When creating training and test datasets you have used the following code

x_train, y_train = dataTrain.iloc[:,:28].values,dataTrain.iloc[:,28:].values
x_train=np.reshape(x_train,(1860,28,1))
x_test, y_test = dataTest.iloc[:,:28].values,dataTest.iloc[:,28:].values
x_test=np.reshape(x_test,(800,28,1))

dataTrain.iloc[:,:28] this is completely wrong. You are still passing the original FTR column(Which is actually the current match result), which is the 0th column.

It should've been dataTrain.iloc[:,1:28] instead

The correct version would've been as described below

x_train, y_train = dataTrain.iloc[:,1:28].values,dataTrain.iloc[:,28:].values
x_train=np.reshape(x_train,(1860,27,1))
x_test, y_test = dataTest.iloc[:,1:28].values,dataTest.iloc[:,28:].values
x_test=np.reshape(x_test,(800,27,1))

When modified correctly it only gives 54% accuracy.

Hence the results produced are completely misleading.

problems with dataCleaning.ipynb

I have tried running through dataCleaning.ipynb and I am not getting quite the same end csv file as you did. And with my new csv there also isn't good prediction percentage in LSTM.ipynb. I also tried fixing what I thought was wrong with dataCleaning file, but no luck. Is there any chance you can share the original code you used for cleaning up the data, so you got such good end results?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.