krbz999 / babonus Goto Github PK

The BAB is not descriptive enough. Each label should have titles, but the keys dialogs will supply the full details.

Basically a type of bonus that is applied to your rolls if your target has a 'transfer to attacker' bonus, or something similar like that.

For use when you want to fake having a +2 AC against ranged attacks and such.

Create a setting that filters out auras by checking if the source actor has any effects with any of the given flags.core.statusId.

• Default value: dead;unconscious.
• Add this extra parameter to the filters when gathering up auras.

or just not in items in compendiums at all.

• items
• same for actors

• Clicking an edit button on a bonus in the BAB workshop should populate the fields with the data of the bonus.
• Sheet should be set to 'edit mode' and not trigger a warning that a bonus with the same label/identifier already exists.

• Add a 'copy' button in the BAB.
• The button should take all fields from the bonus and fill out the form, except for the label and identifier.
• The form should not be set to edit mode.

Code should check if nearest button is disabled.

• add getId and getIds, and deprecate findBonus and getBonusIds.
• add getName and getNames.
• deprecate changeBonusId.
• add getType and deprecate getBonuses.
• add sceneTokensByDisposition.
• add getOccupiedGridSpaces.
• add migration object of migration functions.
• add createBabonus.

They should not be.

• Labels and content of bonus delete dialog are not localized.
• Warnings in the BAB when trying to save with required fields missing is not localized.

A bonus should be able to be toggled via the UI, not just via an ActiveEffect or macro.

Aura config (top row) says 'Enabled' but should say 'Range' or something

The ability score used is not available in the pre hooks for skill and tool checks until hopefully v2.2.0 of the system. #165

Hooks:

• dnd5e.preRollInitiative.
• dnd5e.preRollAbilityTest.
• dnd5e.preRollSkill.
• dnd5e.preRollToolCheck.

Bonuses:

• Parts added on.
• Minimum and maximum on the d20 roll.

Filters:

• Tool type.
• Specific Skills.

• Make Item Types a required field.
• Make Base Items and Weapon Properties only show up if weapon is in Item Types.
• Make Spell Components, Spell Levels, and Spell Schools only show up if spell is in Item Types.

Items:

• Items should have support for a bonus.
• The actor filter should search items for bonuses to apply.
• BAB should not be available for class, subclass, spell, and background type items.
• Items should have a check for requiring attunement/equipped.

Effects:

• Active Effects should have support for a bonus.
• The actor filter should search effects for bonuses to apply.
• Effects should be checked against disabled and isSuppressed (both must be false).

• A warning should be applied if Dice Modifier is selected as the Bonus Type while Save DC is the Bonus Target.
• Apply listener for change on Bonus Target to set Bonus Type to 'Addition'.
• Display warning if Bonus Type - Bonus input is not a static numeric input (no dice rolls for bonus to DC).

• Change input field from number to text.
• Replace roll data of each entry in the hook.
• Try/catch all parts that do not evaluate to an integer.

So the bonus on the left (see image) doesnt apply while the bonus on the right does apply?
(the description and stuff on the right says penalty because I intend to make it a penalty.)
both come from a different wand, that have no mayor differences (one has some spells from items with spells and 2 charges but thats it)

• Apply some css.
• Change 'Required' label, since most aren't required but must match at least one of the selected keys.

It would be nice to have some way to create "on first hit in turn" or "once per turn" bonuses, like the ones from a Rangers Favored Foe , a Zealot Barbarians Divine Fury or a Rogues Sneak Attack. Currently this can only be partially done using midiqol optional flags but it leaves a lot to be desired and this seems to be something that fits the scope of this module

Bonuses are currently transferred as a 2-length array, [id, object-of-values], but this could be extended to 3, with the uuid of the source (to use with fromUuidSync).

Bonuses should apply to preUseItem hook, preRollAttack, and preRollDamage.

• mwak, rwak, msak, rsak, heal should apply if the actionType is such.
• save should apply if actionType is 'save', or hasSave is true.
• Change tooltips and descriptions to match this behavior.

• If a weapon is Finesse, and the ability modifier it uses is set to Default, then a bonus applying to STR or DEX should apply if the relevant modifier is higher than the other.
• If a melee weapon attack uses Default, then bonuses that apply to STR should apply here.
• If a ranged weapon attack uses Default, then bonuses that apply to DEX should apply here.
• If a melee/ranged spell attack uses Default, then bonuses that apply to the actor's spellcasting ability should apply here.

Instead of value: "string", bonuses should be in values: { bonus: "string", ... }, which would allow for more bonus types to be added further down the line.

Which bonus can apply to which roll will be handled in the hooks.

The trashcan in the BAB should delete a bonus from the actor's flags.

• Should be a prompt first.
• Re-render the BAB immediately when deleted.

Currently the dialogs are all unchecked.

Currently you can slap the BAB button in the Special Traits as much as you like.

Allow for the Aura Range to support different system diagonal movement rules.
As well as better calculations using different heights.

See title.

Like itemTypes, it should display a field if death is present in throwTypes.

Would require #13 to be resolved.

This should only apply to damage rolls of course.

• Brutal Critical (more dice) on rwak, msak, and rsak.
• Bonus Critical damage (modifiers on top) on mwak, rwak, msak, and rsak.
• Since core already has the flag for mwak, check if it exists first.

The header, title, button label, and hint are not localized.

• A bonus of '1' lowers the crit range by 1.
• A bonus of '-1' raises the crit range by 1.