kratsg / jetreclustering Goto Github PK

View Code? Open in Web Editor NEW

3.0 5.0 6.0 654 KB

Recluster Jets in a Single Bound!

Home Page: http://kratsg.github.io/JetReclustering

License: GNU General Public License v2.0

C++ 84.38% C 1.48% Python 7.87% CMake 6.28%

physics jet-reclustering jet-moment jet-finding jet-filtering c-plus-plus

jetreclustering's People

Contributors

Stargazers

Watchers

Forkers

zqhsfz j0nburr jdandoy mwkhader mattleblanc jgeisen

jetreclustering's Issues

Fix Unchecked Status Codes

Issue by kratsg
Tuesday May 05, 2015 at 19:10 GMT
Originally opened as kratsg/ReclusteringStudies#1

This comes from Root/Helpers.cxx in setProperty()

Add in configurable pT threshold on the input jets

Intermediate jet containers

Intermediate jet containers sometimes have the same names if the input containers were the same

Comparisons of timing

for comparisons of time, does anyone have the official code that produces the Akt10TrimmedR20PtFrac5 jets that I can just run myself in EL and compare against my tool? I probably would just time how long it takes to run over 1000 events for both methods to state the case. If there's a better recommendation, let me know.

Typo in README -- Tool config uses `fastjet::JetAlgorithm`

Make sure tools are initialized only once

Issue by kratsg
Tuesday May 05, 2015 at 19:10 GMT
Originally opened as kratsg/ReclusteringStudies#2

Unfortunately, for multiple samples, initialized multiple times.

Add in configurable trimming to reclustering code

Issue by kratsg
Friday May 08, 2015 at 15:41 GMT
Originally opened as kratsg/ReclusteringStudies#5

[5/7/15, 5:48:02 PM] Giordon Stark: Well, Pierre says I can probably just write my own
[5/7/15, 5:48:03 PM] Giordon Stark: (he thinks)
[5/7/15, 5:48:08 PM] Giordon Stark: by taking the JetWidthTool that exists.
[5/7/15, 5:48:14 PM] Giordon Stark: and writing a "JetTrimming" tool
[5/7/15, 5:48:35 PM] Giordon Stark: perform some sort of filtering based on the input jet, clear the constituents, re-add only the ones that pass the filtering
[5/7/15, 5:48:42 PM] Giordon Stark: and re-update the jet's total 4-vector

JetRecTool Reclustering decorations

The current iteration of the JetRecTool is missing some useful decorations to help our folks know the original radii of the jets before trimming after reclustering. I've asked for a change to JetFinder here: https://its.cern.ch/jira/browse/ATLJETMET-356

In the meantime, we provide a workaround until the change is propagated higher up.

Request OTP Credit when the time comes

xAODJetReclustering -> JetReclustering

This is a relatively big change.

m_subjet_radius should be default to 0.2 or 0.4

Missing include guards

compiling xAODJetReclustering
Making dependency for ReclusteredJetTrimmingTool.cxx
Making dependency for JetReclusteringTool.cxx
Making dependency for LinkDef.h
Making dependency for LinkDef.h
Making dependency for JetReclusteringAlgo.cxx
Compiling xAODJetReclusteringCINT.o
Compiling JetReclusteringAlgo.o
Compiling ReclusteredJetTrimmingTool.o
Compiling JetReclusteringTool.o
In file included from /share/home/kratsg/MultiBJets/xAODJetReclustering/xAODJetReclustering/JetReclusteringTool.h:41:0,
                 from /share/home/kratsg/MultiBJets/xAODJetReclustering/Root/JetReclusteringAlgo.cxx:6:
/share/home/kratsg/MultiBJets/RootCoreBin/include/JetMomentTools/JetWidthTool.h:14:45: warning: extra ‘;’ [-Wpedantic]
   ASG_TOOL_CLASS(JetWidthTool, IJetModifier);
                                             ^
In file included from /share/home/kratsg/MultiBJets/xAODJetReclustering/xAODJetReclustering/JetReclusteringTool.h:41:0,
                 from /share/home/kratsg/MultiBJets/xAODJetReclustering/Root/JetReclusteringTool.cxx:1:
/share/home/kratsg/MultiBJets/RootCoreBin/include/JetMomentTools/JetWidthTool.h:14:45: warning: extra ‘;’ [-Wpedantic]
   ASG_TOOL_CLASS(JetWidthTool, IJetModifier);
                                             ^
Linking libxAODJetReclustering.so
finished compiling xAODJetReclustering

Verify that we can access btagging link of reclustered constituents

This is probably something super easy to check by dumping the output xAOD I can generate and seeing what exists on the output reclustered jets using my dumper tool https://github.com/kratsg/xAODDumper

Store "effective R" for Variable R jets

Because of trimming, the Effective R cannot be computed as rho/pT, but has to be stored as jet attribute.

Get rid of subjettiness calculations

This was discussed in the email thread, but the calculation of this substructure variable is not going to be very reliable given the low multiplicity of "constituents" being used (eg: input small-R jets).

setProperty and declareProperty in the tool

This will probably need to be written like an AsgTool or at least inherit asg::AsgTool in the class. Let's see what we can do.

Make this tool dual-use

Memory leaks

Need to fix up all memory leaks.