kothariji / bhimintegers Goto Github PK

Step 1 - Fork this repository.
Step 2 - Clone the repository to yuor local machine.
Step 3 - Resolve this bugs, mentions provided in the Issues section of the repository. Also add a description what changes you ahve done.
Step 4 - Add the changes to your repository.
Step 5 - Create a PULL Request. And that's all.

Not compiled without #include <iostream>

BhimInteger n("-350"); BhimInteger n1("-35"); n = n + n1; cout << n; // output => -085

If we try to add -350 and -35 it gives -085, which is not correct.
Before actual addition in add function, the edge cases should be checked like if both numbers are negative or if one is negative and one is not and perform our expression accordingly.

Why the mod operator (%) is not implemented?

using namespace std; - is a bad practice.

If User/Programmer gives invalid input then it doesn't check for the Validation or Handling the error.

For Example

BhimInteger a("--89");
  BhimInteger b("-70");
  cout << a + b;      // output => **--19**

It gives wrong output which is --19 and this does not mean anything.

So, I would like to work on it and also would like to PR by checking the User Input and Handling, if you permit.

Problem

The implementation of division breaks the purpose of the library because the second integer must be at most of the size of a long long int.

static string division(string s1, long long int div)

Platforms

All.