kosmas12 / chip8assembler Goto Github PK

Running Chip8Assembler on a file that contains empty lines(OR A NEWLINE AT THE END OF FILE)

[teufelchen@Squishy ~/Programming/Chip8Assembler (git)-[master] % ./Chip8Assembler example.chip8 
Welcome to Chip8Assembler!
Assembly code file: example.chip8
Succesfully opened example.chip8
Invalid instruction on line 5!
Succesfully wrote machine code to example.c.ch8. Assembly complete!

Additionally even though an error was encountered, it still writes a binary file and claims it was successful.

Currently, in case of any errors, the assembler only returns an error message saying there's an invalid instruction on the currently assembled line. It should be able to tell what the problem is exactly, like wrong instruction, missing commas etc.

Checklist:

• Missing commas
• Invalid instructions
• (Optional) suggesting correct instruction
• Wrong syntax (parameter order)

Hi 🙋‍♀️

you are stating "Syntax" but you provide the Mnemonic instead. Its just a minor thing but I personally would change it.
See Mnemonics on Wikipedia.

The readme does not tell how to compile & run the software.
An example program and how to assemble it would also be great.

./Chip8Assembler example.chip8
Welcome to Chip8Assembler!
Assembly code file: example.chip8
Succesfully opened example.chip8
Succesfully wrote machine code to example.c.ch8. Assembly complete!

I was naming my input file example.chip8(not sure what the intended naming is, the readme does not suggest one).
I expected an output file like rom.bin or similar. Not a weird example.c.ch8.

Compiling this short sample program

CLSC
LDRB 0 0
ADDB 0 1
JUMP 0

Generates this binary:

hexdump example.c.ch8 
0000000 00 e0                                          
0000002

The expected result was:

00 e0 00 60 01 70 00 10