kordan / moodle-mod_surveypro Goto Github PK

When the ability to manage survey elements is taken away from Non-Editing teacher, the ability to Export goes away too. Although export has it's own permission which is still enabled for Non-editing teacher.

The install.xml files appear to have be handwritten.

This should be fixed using the Moodle xmldb editor (under admin > development > XMLDB.)

Please hit the "load" link for your plugin install.xml file in the moodle xmldb editor, and then make Moodle think there is an update to the file (easiest way to do this is to change the description of a table - add a full stop or something similar.) Then get XMLDB to "Save" the updated file which will remove all the old invalid xml from your file.

This is not a blocker for plugins db approval - just a nice to have.

I am working hard on this. 95% made so far. But I can not upload the ZIP (We don’t support that file type). PLEASE tell me an Email address where I can send it (55kb)

Hi,
I am trying to make some surveypro examples for the Moodle documentation. While doing it, I saw some English language strings that I think could be re-written, so that a novel user (me) could better understand what he/she is expected to do.
As I have never before used GitHb, I will likely make quite a few mistakes with the pull requests, and quite likely use a wrong ettiquette. Please be patient with me. I am only trying to help improve a bit an already great plugin.

Is this acceptable ?

After a negative response from a group of students or a response which needs to be addressed. For that we have to make a note / justification and it should be stored on the database.
Like that anything is available?

When i click on the search i Got an Error as follows:

This page did not call $PAGE->set_url(...). Using #http://website.com/mod/surveypro/view_search.php
line 565 of \lib\pagelib.php: call to debugging()
line 773 of \lib\pagelib.php: call to moodle_page->magic_get_url()
line 507 of \local\usertours\classes\manager.php: call to moodle_page->__get()
line 460 of \local\usertours\classes\helper.php: call to local_usertours\manager::get_current_tour()
line 61 of \local\usertours\lib.php: call to local_usertours\helper::bootstrap()
line 1303 of \lib\navigationlib.php: call to local_usertours_extend_navigation()
line 3472 of \lib\navigationlib.php: call to global_navigation->initialise()
line 723 of \lib\pagelib.php: call to settings_navigation->__construct()
line 773 of \lib\pagelib.php: call to moodle_page->magic_get_settingsnav()
line 136 of \blocks\settings\block_settings.php: call to moodle_page->__get()
line 288 of \blocks\moodleblock.class.php: call to block_settings->get_content()
line 230 of \blocks\moodleblock.class.php: call to block_base->formatted_contents()
line 976 of \lib\blocklib.php: call to block_base->get_content_for_output()
line 1028 of \lib\blocklib.php: call to block_manager->create_block_contents()
line 476 of \lib\outputrenderers.php: call to block_manager->ensure_content_created()
line 38 of \theme\essential\layout\redirect.php: call to core_renderer->standard_head_html()
line 1028 of \lib\outputrenderers.php: call to include()
line 958 of \lib\outputrenderers.php: call to core_renderer->render_page_layout()
line 894 of \lib\outputrenderers.php: call to core_renderer->header()
line 2821 of \lib\weblib.php: call to core_renderer->redirect_message()
line 71 of \mod\surveypro\view_search.php: call to redirect()

There are different kind of data collections. For each one, it has to be defined the better strategy to ask for informations.
Let me explain what I mean.

First case

Let's suppose I am inside an hospital ward at the entrance to an examination room. The operator of the hospital has to fill, for each coming patient, this list of informations:

• ID
• gender
• nationality

To record the nationality, surveypro form will provide a drop down menu with the list of some country.
The country where this hospital is will be the default.

Why?
Every time you add a question to a surveypro you have to make the balance between:

• the help (which, in the end, will results in a saving of time for the final user) you want to provide to the final user to fill the form
• the risk to get a record with bad information

If 90% of the patients of the hospital are supposed to be from ES, I will help the final user setting the default of the drop down menu to ES.
The associated risk is that the final user automatically may JUMP that question and submit a wrong information for people with different nationality.
Each VALID default is ALWAYS associated to the risk that the final user "neglects" the corresponding question.

Different cases

If the surveypro is used to create the profile of a user applying to an international public competition, I will NOT provide a default because it is not true that 90% of users are supposed to be from ES.

Even more ... if the information I am asking is important like "When did the described car accident happened?" I can not provide a default because I can not take the risk the question is "jumped" leaving the content of the answer to the default.

Said that, this is why each item has to be equipped with:

• possibility to set a default (for dates the usual defaults are 1: today; 2: a different valid date;)
• possibility to set the default to "choose an answer" that is NOT a valid answer so the final user will be forced to choose the desired answer (otherwise form submission is not permitted).
• in case the answer is not mandatory, there must be the possibility to set the default to "I refuse to answer" or "No answer" or whatever you like.

Now, finally, let me arrive to surveypro.
Dates in surveypro for MOODLE_311_STABLE were written having the possibility to set a default:

• to today
• to a different valid date
• to "Choose an year", "Choose a month", "Choose a day"
• to "No answer"

In the frame of the upgrade of the code from MOODLE_311_STABLE to MOODLE_400_STABLE I tried to extend the mform
class surveypromform_date extends \ MoodleQuickForm_date_selector {
to make use of the Gregorian calendar in js but it does not support the default "Choose an year", "Choose a month", "Choose a day".

Is there a way to make this option available into MoodleQuickForm_date_selector?

I love the mod, but I am having an issue. I'm attempting to have a set of questions for students and some reserved fields at the end for non-editing teachers. I was easily able to achieve this, but the issue I'm having is that when a student enters the activity it seems they are directed to the responses tab, which they don't have access to, the same thing happens after completing submitting their form. It doesn't break anything it just shows an error message in both cases stating the database cannot be reached. Is there a setting I missed that would leave out the responses tab, or is there a change I can make in code to leave it out? Any help would be appreciated.

Adding more than a picture to the content of an item, only one of them is displayed but not the others.

For some time travis has been failing completely, making it unusable. This issue is about to get it back to work and, hopefully, pass.

Maybe some of the tasks (phpunit, behat) will be moved out from travis, leaving only static (and quick) checks. Let's see...

Ciao :-)

Notice: Undefined property: surveyproformat_label_format::$extranote in Root\moodle\mod\surveypro\classes\itembase.php on line 1411

Just dropping a note here in case you missed it in the forums:

https://github.com/kordan/moodle-mod_surveypro/blob/master/field/checkbox/lang/en/surveyprofield_checkbox.php#L44

string concatenation in the lang packs is not allowed - it causes problems for the Moodle translation tool

eg:
$string['test'] = "sometext"."somemoretext";
or
$string['test'] = "sometext".$string['someotheritem'];

each string must be contained within one set of quotes eg:
$string['test'] = "sometext somemoretext";

Hello Kordan,
we are using SurveyPro plugin on all of our sites, and it is great. But lately we have a problem that SurveyPro is deleting some of our clients submissions. Message from log is stating "user with ID 2 (admin) has deleted the submission with ID 549" and origin is "cli".
That is very unfortunate for us because we need to keep clients response (even they are partial), and Counselors need to be able to add or change information in restricted part of Survey sometimes after 2 -6 months.
Can you please give us file and line where is that set, and if you can put that as option in future versions of SurveyPro.

Please, reconsider.

It is not strictly necessary to have unit testsin your plugin.

Your plugin IS GOOD enough.
There are 11 forks of it already.

I really think it would be very useful for many Moodlers (such as myself and my school teachers).

You needn't worry about user complains. Let the users find areas of improvement. Fixes will come eventually.

We are using SurveyPro on our production site, and one of colleague find that multiple selection field is just exporting first option from the list, doesn't show real user selection.

The following query will fail on postgresql (my version is 9.13.14).

https://github.com/kordan/moodle-mod_surveypro/blob/master/db/upgradelib.php#L72-L77

My work around was:

$sql = 'SELECT DISTINCT ON (parentid) id as childid, parentid, surveyproid FROM {surveypro_item} WHERE type = :type AND parentid <> :parentid ORDER BY parendit, surveyproid, sortindex';

however I am not creating a pull request because I don't know if this is MySQL compatible.

Cheers,

Hello Kordan,

now, when I am already here, just one quick question. We have a lot of "in progress" responses with this explanation, can you give me some code change that will turn off any verification (not verification of fields by setting). If that is too complicated, can you explain what is causing that error message, to try to give a warning to our clients. As you maybe remember we are accepting our clients answers as they are, because they will have online meeting with Counselor where he can fix all issues. We just need that our clients submit the form with their part of questions, and to their response be "closed" (not "in progress"), and Counselor will do the rest, fixing some clients answers, and fill they own part of form (202 questions).
Thanks in advance, and just to be clear 50-something are best years in life. :)

Vladimir

hi team,
I need to make a report for the survey depends on the sections which i created.

I would suggest you update your readme and deprecate the use of the moodle tracker for tracking issues and instead rely on the github issues tracker - it allows for better tracking of pull requests matching issues, and generally provides a better experience for contributors compared with using the Moodle HQ JIRA.

This is NOT a blocker for plugins db approval.

Hi,
One suggestion for one English language string: mod_surveypro mastertemplate_help
'Choose the master template you want to apply to your survey.'

This help string does not help much :(

Maybe it would help more if it actually described the available survey types; e.g.

'Choose the master template you want to apply to your survey. The available types are:

• ATTLS. ''Attitudes to Thinking and Learning Survey''. See https://docs.moodle.org/31/en/Survey_settings#ATTLS_-_Attitudes_to_Thinking_and_Learning_Survey.
• COLLES. ''Constructivist On-Line Learning Environment Survey''. See https://docs.moodle.org/31/en/Survey_settings#COLLES_-_Constructivist_On-Line_Learning_Environment_Survey.
• CRITICAL INCIDENTS. See https://docs.moodle.org/31/en/Survey_settings#Critical_incidents.'

The links to the current documentation pages might be written as 'More information...' or a similar text.

Thanks in advance for your help improving this already great plugin.

Please fix:
surveyprofield_checkbox adjustment_help

'How this list of items will be shown? In horital or in vertical?'

'horital' should be 'horizontal'

in your styles.css you define a number of generic styles that could clash with core moodle code or other locations where simliar names are used. Mooodle combines the styles.css file from all plugins into a single file to improve caching, but this means your styles need to be specific to prevent them being applied to Moodle components outside the surveypro plugin.

Moodle helpfully adds a number of classes to the body tag based on the path that you can use such as:
eg if you are have a file in mod/assign you would see the following class added to the body tag
path-mod-assign
so if you have an item with the class "filething" on the page you would target it like:

.path-mod-assign .filething {
   color: red;
}

Please make sure your css classes in styles.css are specific enough so they cannot clash with other core code - as this can potentially cause clashes with other core code and css issues are quite hard to trace this is usually a moodle.org plugins db approval blocker (but it should hopefully be an easy fix!)