komrad36 / ellipticcurvefactorization Goto Github PK

FactorInfo probably needs a copy constructor and a destructor that either makes a deep copy and clears m_factor or does ref counting to clear m_factor when the last copy of the struct is destroyed. A ref counting wrapper on m_factor, itself, would be another option.

The deep copy and clear was sufficient for my purposes but it might be a bit inefficient as copies get made in SqrtModComposite.

Otherwise things seem to work great but I haven't actually used the factorization (I had known factors) so I could have missed other issues.

Thanks, by the way. I'm just doing a bit of research and had a hypothesis I wanted to test. This saved me some time I probably wouldn't have been able to justify spending on a longshot. It didn't pan out but it would have bothered me to not try.