komodoplatform / komodo-wallet-desktop Goto Github PK

For UI layout and UX please orientate towards these mockups:

Seed input is TextArea normally, so it can have multiple lines.

At recovery page, seed is hidden in mobile so I did the same here. Though TextArea does not offer a way to hide the password, but TextField does. So what I did is to have TextArea and TextField, make the TextField hidden like a password, and make only one of them visible. So when you hide, it shows TextField, and when user clicks the eye icon, TextField hides and TextArea is being visible, showing multiple lined seed.

Having this hacky solution (I think mobile does a similar thing) broke the TAB order.

At this screenshot state, pressing TAB makes the focus invisible, then pressing again makes it go to the very top again. This is the problem, we expect it to continue to Allow custom seed checkbox.

I spent some time trying different stuff with KeyNavigation.tab and activeFocusOnTab but I couldn't get the desired result. Will take a look later, just saving it here so we don't forget.

Hi, is it possible to integrate an copy function? For example i try to copy the swap id but its not possible. Thank you

Issue: It is currently not possible to export the 'recent swaps' list for the UI.

Use case: Analytics, evaluation of trade strategies, bots, backtesting, to support importing into accounting software and/or paying taxes on trades, as unpopular as they maybe.

Suggestion: Allow export to CSV and XLSX formats.
Nice to have: If a filter is introduced, the export should respect the filtered list (e.g export only successful swaps).

https://github.com/KomodoPlatform/atomicDEX-Pro/blob/fd4eb402cbd842726cac728739bea23829d80c00/atomic_qt/atomic_qt_design/qml/Screens/Login.qml#L48-L53

This issue was generated by todo based on a TODO comment in fd4eb40. It's been assigned to @naezith because they committed the code.

Issue: It is currently not possible to clear out the swap history from within the UI.

If a swap filter is introduced for the list, the 'clear' history should respect the filter and only delete the displayed swaps.

Property: Q_PROPERTY(QString balance_fiat_all READ get_balance_fiat_all WRITE set_current_balance_fiat_all NOTIFY on_fiat_balance_all_changed)

Close with commit url when it's done !

https://github.com/KomodoPlatform/atomicDEX-QT/blob/ca8cb9f5e62d5c2ed380b002babde21616f04fa0/src/atomic.dex.gui.cpp#L488-L493

This issue was generated by todo based on a TODO comment in ca8cb9f. It's been assigned to @Milerius because they committed the code.

Hi, is it possible to integrate an contact list to send function?

Thank you

After running ./ci_tools_atomic_dex build debug

CMake Error at ci_tools_atomic_dex/vcpkg-repo/scripts/buildsystems/vcpkg.cmake:286 (_find_package):
  Could not find a package configuration file provided by "EnTT" with any of
  the following names:

    EnTTConfig.cmake
    entt-config.cmake

Further research skypjack/entt#451 shows a similar issue being worked on about 8hrs ago.

tx_fee + erc_fees

Please confirm that this is correct.

Currently Send button is disabled when coin is syncing, and other 2 are not. There is also Claim Rewards at some coins.

Swap button and Trading is also enabled while it's syncing.

I need to know which ones of these 4 will be blocked when coin is syncing.

balance on trade tab is showed in wrong format when balance is low

https://github.com/KomodoPlatform/atomicDEX-QT/blob/43c111c503ab9757ad4acf210733facb62997151/src/atomic.dex.gui.cpp#L302-L306

This issue was generated by todo based on a TODO comment in 43c111c. It's been assigned to @naezith because they committed the code.

List of known issues with ci_tools_atomic_dex automated builds.
Need to be fixed to have proper cd releases.

-- MacOS:

1. atomicDEX-Pro.dmg has no icon

2. debug builds do not start with debug console/log

-- Windows:

3. similarly to (2) - release builds start with cmd debug console/log

4. vcpkg does not build debug libs to provide with bundle-Debug.
   a.e.: libcurl-d.dll, boost-filesystem-gd-mt.dll, etc.

-- Linux:

6. Linux builds require shared dependencies (*.so ), currently vcpkg does not support shared libs builds. Thus, we should either build static binary or search for a workaround.

https://github.com/KomodoPlatform/atomicDEX-Pro/blob/b74831c6b5a11e56d8eca1d7f364845f57dd8349/atomic_qt/atomic_qt_design/qml/Wallet/Wallet.qml#L13-L18

This issue was generated by todo based on a TODO comment in b74831c. It's been assigned to @naezith because they committed the code.

https://github.com/KomodoPlatform/atomicDEX-QT/blob/ed240c2e4b0825828ac4691d4869a29774f28be7/src/atomic.dex.gui.cpp#L436-L441

This issue was generated by todo based on a TODO comment in ed240c2. It's been assigned to @naezith because they committed the code.

I will add in the backend a current_coin_info.state that can be InProgress or Finished

If it's InProgress we need to show in the UI a Spinning Circle + the message Loading Syncing + current_coin_info.current_block TXs

State and Current block are not yet available

The transactions arrive little by little during synchronization, we display the spinning loading + the transactions step by step when state goes to Finished, we remove the spinning effect and the message

https://github.com/KomodoPlatform/atomicDEX-Pro/blob/491f431100c0d09ed3966141b4477ad7e47bd15b/atomic_qt/atomic_qt_design/qml/Screens/InitialLoading.qml#L19-L23

This issue was generated by todo based on a TODO comment in 491f431. It's been assigned to @naezith because they committed the code.

QVariantMap jsonmodel:

{
  "491df802-43c3-4c73-85ef-1c4c49315ac6": {
    "events": [
      {
        "Started": {
          "human_timestamp": "19 Janvier 2020 19h37"
        }
      },
      {
        "Finished": {
          "human_timestamp": "19 Janvier 2020 19h38"
        }
      }
    ],
    "taker_coin": "BTC",
    "maker_coin": "KMD",
    "maker_amount": "1",
    "taker_amout": "1",
    "type": "Taker",
    "my_info": {
      "my_amount": "1",
      "my_coin": "BTC",
      "other_amount": "1",
      "other_coin": "KMD",
      "started_at": 1561481967
    }
  }
}

https://github.com/KomodoPlatform/atomicDEX-QT/blob/3dd168a44a6aa4d5599f44f94fe0b13937784424/src/atomic.dex.gui.cpp#L217-L222

This issue was generated by todo based on a TODO comment in 3dd168a. It's been assigned to @naezith because they committed the code.

Recommendation: Rename "cancel" to "Cancel Order"

Right now both buttons "close" and "cancel" could appear to mean the same thing.

In general, a button labelled 'Cancel' refers to "close the dialog and return to the previous state of the application".

A 'Close' button in general means: "I am done, close this thing with the changes I already made."

Win10.

Issue: The current orders list auto-jumps to the top every few seconds. Possibly the result of the orderbook call.

Expected: When scrolling the orderbook, the window position does not auto-jump :-)

Nice to have: remember the position of the list when toggling between tabs Trade/Orders/History

Testing version v0.1.2 on Win10 on a 15" screen: lower part of the app is hidden, including buttons necessary to continue. On a 24" screen at the highest resolution it's all fine, though the buttons look small on a large surface. If the 24" screen gets scaled at 125 or 150% resolution, lower part gets hidden again.

Attached examples:

15"

24" at highest resolution

24" scaled at 150%

https://github.com/KomodoPlatform/atomicDEX-Pro/blob/7b9663d6b03e18af826f1236341ffdf368a2d9bf/CMakeLists.txt#L58

switch to https://github.com/komodoplatform/coins

To be able to recover the rewards of a coin we need several notions:

Is my currency a currency on which the rewards exist (coin_info.is_claimable == true)

Does my currency allow the recovery of the rewards and has the minimum amount to claim the reward (coin_info.is_claimable && balance(current_coin) > coin_info.minimal_claim_amount)

Does my currency allow the recovery of the rewards and has the minimum amount to claim the reward and i didn't claim it since one hours (coin_info.is_claimable && balance(current_coin) > coin_info.minimal_claim_amount && is_claiming_ready(current_coin.ticker))

C++ function will be exposed when ready

In Trade Screen

• Select Sell Coin and update balance to something less than Max
• Open Receive Coin Orderbook
• Select swap from order book
• When you go back to the Trade Screen the Sell Amount has reset to Max

• In the backend we have:

        Q_INVOKABLE QVariantMap get_my_orders();

Which is a json / javascript object that look like:

{
  "BTC": {
    "orders": {
      "maker_order": [
        {
          "rel": "KMD",
          "base": "BTC",
          "date": "19 Janvier 2020",
          "cancellable": true,
          "base_amount": "1",
          "rel_amount": "1",
          "order_id": "4321"
        }
      ],
      "taker_order": [
        {
          "rel": "ETH",
          "base": "BTC",
          "date": "20 Janvier 2020",
          "cancellable": true,
          "base_amount": "1",
          "rel_amount": "1",
          "order_id": "1234"
        }
      ]
    }
  }
}

The C++ struct is:

struct qt_my_order_contents : QObject
    {
        Q_OBJECT
      public:
        explicit qt_my_order_contents(QObject* parent = nullptr);
        QString m_order_id;
        QString m_date;
        QString m_base;
        QString m_rel;
        bool    m_cancellable;
        QString m_base_amount;
        QString m_rel_amount;
        QString m_price;

        Q_PROPERTY(QString price READ get_price CONSTANT MEMBER m_price)
        Q_PROPERTY(QString date READ get_date CONSTANT MEMBER m_date)
        Q_PROPERTY(QString base READ get_base CONSTANT MEMBER m_base)
        Q_PROPERTY(QString rel READ get_rel CONSTANT MEMBER m_rel)
        Q_PROPERTY(bool cancellable READ is_cancellable CONSTANT MEMBER m_cancellable)
        Q_PROPERTY(QString base_amount READ get_base_amount CONSTANT MEMBER m_base_amount)
        Q_PROPERTY(QString rel_amount READ get_rel_amount CONSTANT MEMBER m_rel_amount)
        Q_PROPERTY(QString uuid READ get_uuid CONSTANT MEMBER m_order_id)

        [[nodiscard]] QString get_uuid() const noexcept
        {
            return m_order_id;
        }

        [[nodiscard]] bool
        is_cancellable() const noexcept
        {
            return m_cancellable;
        }

        [[nodiscard]] QString
        get_base_amount() const noexcept
        {
            return m_base_amount;
        }

        [[nodiscard]] QString
        get_rel_amount() const noexcept
        {
            return m_rel_amount;
        }

        [[nodiscard]] QString
        get_base() const noexcept
        {
            return m_base;
        }

        [[nodiscard]] QString
        get_rel() const noexcept
        {
            return m_rel;
        }

        [[nodiscard]] QString
        get_price() const noexcept
        {
            return m_price;
        }

        [[nodiscard]] QString
        get_date() const noexcept
        {
            return m_date;
        }
    };

    struct qt_my_orders : QObject
    {
        Q_OBJECT
      public:
        explicit qt_my_orders(QObject* parent = nullptr);
        QObjectList m_taker_orders;
        QObjectList m_maker_orders;

        Q_PROPERTY(QObjectList taker_orders READ get_taker_orders CONSTANT MEMBER m_taker_orders)
        Q_PROPERTY(QObjectList maker_orders READ get_maker_orders CONSTANT MEMBER m_maker_orders)

        [[nodiscard]] QObjectList get_taker_orders() const noexcept
        {
            return m_taker_orders;
        }

        [[nodiscard]] QObjectList
        get_maker_orders() const noexcept
        {
            return m_maker_orders;
        }
    };

It would be great to disable the send button if user can't even pay the withdraw fees.

Here is how to have it by providing only the ticker:

curl -s --url "http://127.0.0.1:7783" --data "{\"userpass\":\"$userpass\",\"method\":\"get_trade_fee\",\"coin\":\"ETH\"}" | json_pp
{
   "result" : {
      "coin" : "ETH",
      "amount" : "0.0009"
   }
}

When i let AtomicDEX-Pro run for a longer period of time (eg 24h), it segfaults.
So i restarted it with gdb and collected this backtrace:

(gdb) backtrace
#0  0x00007ffff6abd7a4 in QV4::MarkStack::push (this=0x7fffffffaf10, m=0x7fff69a68220) at ../../include/QtQml/5.14.2/QtQml/private/../../../../../src/qml/memory/qv4mmdefs_p.h:280
#1  QV4::Heap::Base::mark (markStack=0x7fffffffaf10, this=0x7fff69a68220) at ../../include/QtQml/5.14.2/QtQml/private/../../../../../src/qml/memory/qv4heap_p.h:192
#2  QV4::Value::mark (markStack=0x7fffffffaf10, this=<optimized out>) at jsruntime/qv4value_p.h:362
#3  QV4::WeakValue::markOnce (this=<optimized out>, markStack=0x7fffffffaf10) at jsruntime/qv4persistent.cpp:415
#4  0x00007ffff6b2c2a0 in markChildQObjectsRecursively (parent=parent@entry=0x7fffffffdc98, markStack=markStack@entry=0x7fffffffaf10) at jsruntime/qv4qobjectwrapper.cpp:1134
#5  0x00007ffff6b2c34b in QV4::Heap::QObjectWrapper::markObjects (that=0x7fffece2ba40, markStack=0x7fffffffaf10) at jsruntime/qv4qobjectwrapper.cpp:1153
#6  0x00007ffff6a4441f in QV4::MarkStack::drain (this=this@entry=0x7fffffffaf10) at memory/qv4mm.cpp:863
#7  0x00007ffff6abd142 in QV4::PersistentValueStorage::mark (this=<optimized out>, markStack=markStack@entry=0x7fffffffaf10) at jsruntime/qv4persistent.cpp:243
#8  0x00007ffff6a4479d in QV4::MemoryManager::collectRoots (this=this@entry=0xfc2820, markStack=markStack@entry=0x7fffffffaf10) at memory/qv4mm.cpp:876
#9  0x00007ffff6a44989 in QV4::MemoryManager::mark (this=this@entry=0xfc2820) at memory/qv4mm.cpp:917
#10 0x00007ffff6a4675b in QV4::MemoryManager::runGC (this=this@entry=0xfc2820) at memory/qv4mm.cpp:1052
#11 0x00007ffff6a48ac8 in QV4::MemoryManager::allocate (size=32, allocator=0xfc2830, this=0xfc2820) at ../../include/QtQml/5.14.2/QtQml/private/../../../../../src/qml/memory/qv4mm_p.h:307
#12 QV4::MemoryManager::allocString (this=this@entry=0xfc2820, unmanagedSize=<optimized out>) at memory/qv4mm.cpp:787
#13 0x00007ffff6aa7711 in QV4::MemoryManager::allocWithStringData<QV4::String, QString> (arg1=..., unmanagedSize=<optimized out>, this=0xfc2820) at ../../include/QtQml/5.14.2/QtQml/private/../../../../../src/qml/memory/qv4mm_p.h:217
#14 QV4::ExecutionEngine::newString (this=this@entry=0xfc6a90, s=...) at jsruntime/qv4engine.cpp:890
#15 0x00007ffff6b30682 in loadProperty (v4=0xfc6a90, object=0x7fffffffdc98, property=...) at jsruntime/qv4qobjectwrapper.cpp:157
#16 0x00007fffd9404653 in ?? ()
#17 0x0000000000000000 in ?? ()

seems to happen in process_fees loop... this is from console

16:26:20.425 [fees thread     ]     atomic.dex.mm2.cpp:601   INFO| .   { process_fees
...
...
...
16:26:20.468 [orderbook thread] atomic.dex.mm2.api.cpp:605   INFO| .   .   resp: {"result":{"amount":"0.00021125","coin":"BTC"}}
16:26:20.561 [fees thread     ] atomic.dex.mm2.api.cpp:605   INFO| .   .   resp: {"result":{"amount":"0.00001039","coin":"LTC"}}

then it segfaults

We lack this warning. Mobile app clears the input box and puts that error if your amount is too low. Perhaps we need a min_trade_amount from backend?

All dates are currently UTC. We need to have them for local time, mine is UTC+3 for example. mm2 does not provide that, we need to add the timezone in backend on top of that timestamp I suppose.

I was following the building instructions for Windows.

I had Visual Studio 2019 installed before but Desktop development with C++ was not selected. And I was not aware.

A tiny problem was this:

D:\Projects\atomicDEX-Pro\atomic_qt\ci_tools_atomic_dex>./ci_tools_atomic_dex.exe build release
'.' is not recognized as an internal or external command,
operable program or batch file.

After running it, for first time, I got this error:

Then it took a while to figure out that it's because Desktop development with C++ was not installed. I installed that.

At my next try, it failed like this:

D:\Projects\atomicDEX-Pro\atomic_qt\ci_tools_atomic_dex>ci_tools_atomic_dex.exe build release
D:\Projects\atomicDEX-Pro\atomic_qt\ci_tools_atomic_dex\vcpkg-repo\vcpkg
D:\Projects\atomicDEX-Pro\atomic_qt\ci_tools_atomic_dex\vcpkg-repo\scripts\buildsystems\vcpkg.cmake
Downloading packages ... please wait
D:\Projects\atomicDEX-Pro\atomic_qt\ci_tools_atomic_dex\src\ci_tools_atomic_dex.nim(52) ci_tools_atomic_dex
D:\Projects\atomicDEX-Pro\atomic_qt\ci_tools_atomic_dex\src\ci_tools_atomic_dex.nim(42) main
D:\Projects\atomicDEX-Pro\atomic_qt\ci_tools_atomic_dex\src\build.nim(7) build_atomic_qt
D:\Projects\atomicDEX-Pro\atomic_qt\ci_tools_atomic_dex\src\generate.nim(12) generate_solution
D:\Projects\atomicDEX-Pro\atomic_qt\ci_tools_atomic_dex\src\dependencies.nim(21) download_packages
C:\ProgramData\scoop\apps\nim\current\lib\pure\osproc.nim(750) execCmd
C:\ProgramData\scoop\apps\nim\current\lib\pure\includes\oserr.nim(94) raiseOSError
Error: unhandled exception: The system cannot find the file specified.
 [OSError]

D:\Projects\atomicDEX-Pro\atomic_qt\ci_tools_atomic_dex>

When I saw nim complaining, I remembered that after scoop install nim --global, my antivirus BitDefender removed a file inside that, and I restored that file. But I had no other clue so I thought this is because of that BitDefender issue. I added exceptions, tried many many different stuff to reinstall nim, but it was always being stuck at Extracting nim.... It installed fine when I removed --global.

I thought it will work at this point but when I tried, I got exactly the same error. Then I digged into
dependencies.nim and vcpkg.nim and found these two parts:

proc check_if_vcpkg_exists*(): bool =
    result = os.existsDir("vcpkg-repo")

proc install_vcpkg*() =
    set_vcpkg_path()
    if not check_if_vcpkg_exists():
        echo "Installing vcpkg"
        discard execCmd("git clone https://github.com/microsoft/vcpkg vcpkg-repo")
        build_vcpkg()
        integrate_vcpkg()
    else:
        echo "vcpkg repo exist"
        build_vcpkg()
        integrate_vcpkg()

After seeing that check_if_vcpkg_exists function, I deleted vcpkg-repo folder. And the build started running this time.

Yes, all of this chain of problems is caused by Desktop development with C++ not being installed.

I thought this time it will run perfectly but after a really long build, it failed.
Here is the log: https://paste.ubuntu.com/p/tnqqYM92PN/

EnTT problem continues here: #36 (comment)

Issue: The Orders page currently does not allow to display all active orders, only per coin.

Suggestion: Add a 'show all' or 'clear filter' option to the drop down menu:

For an active trader, soon enough the list would grow too large to be manageable.

Possible Filters:

• Successful
• Failed
• Coin Bought
• Coin Sold

Both Win and Linux versions. When activating Ethereum there's a spinning loading wheel in its page. I see from etherscan that it started at the most recent block and the count increases keeping up with new ethereum blocks. I left it running for one hour with no change. Is that expected behaviour? I previously noticed the same with atomicdex mobile on android.

Even if RPC returns an error,

22 13:56:49, rpc:305] RPC error response: rpc:274] lp_coins:536] utxo:1391] utxo:654] Output value 0 is less than dust amount 1000

API returns "has_error":false,"error_message":""

This one is just a test with 0 amount send, which won't be allowed by front-end anyways.

But for all API calls we need to make sure they check the RPC error responses and return them.

https://github.com/KomodoPlatform/atomicDEX-QT/blob/43c111c503ab9757ad4acf210733facb62997151/src/atomic.dex.gui.cpp#L192-L197

This issue was generated by todo based on a TODO comment in 43c111c. It's been assigned to @naezith because they committed the code.

Hover is ignored when cursor is on graph.

ChartView component is used https://doc.qt.io/qt-5/qml-qtcharts-chartview.html

Trade Screen

• Select Dash - Max balance
• Select KMD to receive
• Confirm Swap

Swap never shows up as active

Suspect this is the same Max value for Dash issue that is in Mobile version but with no error handling to let user know it failed.

Was able to get a successful Dash > KMD swap when I reduced the Dash amount slightly.

At this view, I need to check if user has enough balance for this withdraw call.

I do the check balance >= amount at the moment. But it's more complex than that of course.

User enters amount, gas (Gwei), gas_price (Gwei). And I have the info for ETH balance.

What the correct statement should be?

Is it erc20_coin_balance >= amount && eth_balance >= (gas * gas_price)/1,000,000,000?

But then if erc20_coin is ETH, is it being eth_balance >= amount + (gas * gas_price)/1,000,000,000?

So there are two cases.

12 13:47:02, rpc:307] RPC error response: rpc:276] lp_ordermatch:697] utxo:1443] BCH balance 0.00837406 is too low, required 0.00846328

12 13:51:14, rpc:307] RPC error response: rpc:276] lp_ordermatch:697] utxo:1443] LTC balance 0.0098383 is too low, required 0.00992564

If i try to swap the entire balance (BCH/LTC) to KMD, mm2 shows the above errors and the order is not created.

btw, BCH fee is always {"result":{"amount":"0.00001","coin":"BCH"}}, it is fixed.

I will add in each transaction a adjusted_amount field that will be displayed by the UI only in the transaction history, we still use full amount in the tx details

Hi,

all my swaps stucks at 2/3 Swap ongoing.

Thank you

Installing 0.1.3 on a fresh Windows 10 (in Virtualbox), AtomicDex asks for missing msvcp140.dll & vcruntime140_1.dll

https://github.com/KomodoPlatform/atomicDEX-QT/blob/d60c5ce67f253e93169a986464571cb7d441bd27/src/atomic.dex.mm2.config.hpp#L44-L49

This issue was generated by todo based on a TODO comment in d60c5ce. It's been assigned to @Milerius because they committed the code.

https://github.com/KomodoPlatform/atomicDEX-QT/blob/3dd168a44a6aa4d5599f44f94fe0b13937784424/src/atomic.dex.gui.cpp#L189-L194

This issue was generated by todo based on a TODO comment in 3dd168a. It's been assigned to @naezith because they committed the code.

Seed is displayed with TextArea component. TextField is hiding passwords like echoMode: hidable && hiding ? TextInput.Password : TextInput.Normal but TextArea does not have that field.

There is this https://doc.qt.io/qt-5/qml-qtquick-controls-textarea.html#inputMethodHints-prop but Qt.ImhHiddenText does not work I think.

Not many posts online about this field,
https://forum.qt.io/topic/107470/in-textfield-not-work-qt-imhhiddentext
https://bugreports.qt.io/browse/QTBUG-79079?filter=-4&jql=text%20~%20%22ImhHiddenText%22%20order%20by%20created%20DESC

I couldn't solve it since I couldn't find a good way. Saving it here.

https://github.com/KomodoPlatform/atomicDEX-QT/blob/f6f35bd9663ddb26c615f4c69cfb56fd75746c5d/src/atomic.dex.gui.cpp#L47-L66

fyi - for the production version we will use rational datatype (in the "backend") when it comes to order-handling since the logic there does require divisions/multiplications at some point - for API fetched data like balance and TX amounts we will be using fixed-point arithmetic to calculate USD value, etc. thus storing these amounts in integer representations (cents/pennies) - for arithmetic operations on and representations of decimal nums we will use one of the arbitrary-precision arithmetic libraries like gmp, mpfr, etc.

relevant infos:
https://bitcointalk.org/index.php?topic=13837.0
https://stackoverflow.com/questions/3730019/why-not-use-double-or-float-to-represent-currency

https://ieeexplore.ieee.org/document/8766229
https://gmplib.org/
https://www.mpfr.org/
https://en.wikipedia.org/wiki/List_of_arbitrary-precision_arithmetic_software
https://en.wikipedia.org/wiki/List_of_C%2B%2B_multiple_precision_arithmetic_libraries

f6f35bd#r36293782

https://github.com/KomodoPlatform/atomicDEX-QT/blob/3577a042319d9715f468179080d4967ebefee6a2/src/atomic.dex.gui.cpp#L267-L270

This issue was generated by todo based on a TODO comment in 3577a04. It's been assigned to @naezith because they committed the code.