komapeb / data_connection_checker Goto Github PK

Will this library be upgraded to null-safety?

throws SocketException when connecting to https://1.1.1.1 which seem to be down. Exception cannot be handled as it is not bubbled up to the calling function and as a result it causes the app to hang.

Currently the logic is "All addresses are pinged simultaneously. ... When all the requests complete with either success or failure, a check is made to see if the list contains at least one true boolean.". However if any of the hosts slow to respond (for example for some reason CloudFlare DNSes don't respond (#10 (comment)) then we have to wait a timeout (10 seconds). In my opinion if any of the pings succeed then the test could already cut short any other pings and return immediately.

Migrate to sound null safety
Bump up package version

I see the error below when targeting web. Not sure if this is just a limitation of flutter for web at this point or a problem with this library.

errors.dart:145 Uncaught (in promise) Error: Unsupported operation: InternetAddress
    at Object.throw_ [as throw] (errors.dart:191)
    at Function.new (io_patch.dart:408)
    at get DEFAULT_ADDRESSES (data_connection_checker.dart:61)
    at Function.desc.get [as DEFAULT_ADDRESSES] (utils.dart:75)
    at new data_connection_checker.DataConnectionChecker.__ (data_connection_checker.dart:89)
    at get _instance (data_connection_checker.dart:109)
    at Function.desc.get [as _instance] (utils.dart:75)
    at Function.new (data_connection_checker.dart:93)
    at network_info.NetworkInfoImpl.new._checkConnection (network_info.dart:39)
    at _checkConnection.next (<anonymous>)
    at runBody (async_patch.dart:84)
    at Object._async [as async] (async_patch.dart:123)
    at network_info.NetworkInfoImpl.new.[_checkConnection] (network_info.dart:38)
    at new network_info.NetworkInfoImpl.new (network_info.dart:16)
    at main$ (main.dart:62)
    at main$.next (<anonymous>)
    at onValue (async_patch.dart:45)
    at _RootZone.runUnary (zone.dart:1379)
    at _FutureListener.thenAwait.handleValue (future_impl.dart:137)
    at handleValueCallback (future_impl.dart:678)
    at Function._propagateToListeners (future_impl.dart:707)
    at _Future.new.[_completeWithValue] (future_impl.dart:522)
    at future.dart:400
    at _RootZone.runUnary (zone.dart:1379)
    at _FutureListener.then.handleValue (future_impl.dart:137)
    at handleValueCallback (future_impl.dart:678)
    at Function._propagateToListeners (future_impl.dart:707)
    at _Future.new.[_completeWithValue] (future_impl.dart:522)
    at async._AsyncCallbackEntry.new.callback (future_impl.dart:552)
    at Object._microtaskLoop (schedule_microtask.dart:41)
    at _startMicrotaskLoop (schedule_microtask.dart:50)
    at async_patch.dart:166

Also seeing warnings during build:

Skipping compiling my_proj|lib/main_web_entrypoint.dart with ddc because some of its
transitive libraries have sdk dependencies that not supported on this platform:

data_connection_checker|lib/data_connection_checker.dart

It would be a great enhancement if you could add a property to add custom addresses instead of the default ones.
example code would be:

DataConnectionChecker(ipAddresses:<ipAddress>[]);

If mobile data is on, and the data has gone. The plugin shows that there is internet connectivity.

Hello,
please check the screenshot, it's from my app https://well-spoken.app .

Apple is mysterious in their review process, I haven't changed anything in networking for 20 updates, and now they came up with this when rolling new features.

As you see on the screenshot, they were testing my app on iPad, and there is an additional layer of complexity - VPN, maybe it affects querying DNSes? I saw some other comments, perhaps we should use IPV6? Perhaps if all DNSes fail I should do additional request to my own server to verify the status of the network?

I'm using most recent version of data_connection_checker.

I managed to convenience them to accept it without changes, but I'm afraid it's not a sustainable solution.

The current Dart SDK version is 3.2.3.
Project depends on data_connection_checker any which doesn't support null safety, version solving failed.
The lower bound of "sdk: '>=2.2.0 <3.0.0'" must be 2.12.0 or higher to enable null safety.

flutter: No internet :( Reason:
flutter: [AddressCheckResult(AddressCheckOptions(InternetAddress('1.1.1.1', IPv4), 53, 0:00:10.000000), false), AddressCheckResult(AddressCheckOptions(InternetAddress('8.8.4.4', IPv4), 53, 0:00:10.000000), false), AddressCheckResult(AddressCheckOptions(InternetAddress('208.67.222.222', IPv4), 53, 0:00:10.000000), false)]

I am using a school wifi connection and data_connection_checker is failing when tries to connect internet. I tried a different wifi (my phone's), it worked.

I am hoping this can be fixed because the app I am developing is focusing on students and they will be at school most of the time :)

A SocketException is thrown whenever I call the hasConnection method when the device is offline.

class NetworkInfoImpl implements NetworkInfo{
  final DataConnectionChecker connectionChecker;

  NetworkInfoImpl(this.connectionChecker);
  @override

  Future<bool> get isConnected => connectionChecker.hasConnection;

}

SocketException (SocketException: Connection failed (OS Error: Network is unreachable, errno = 101), address = 1.1.1.1, port = 53)
SocketException (SocketException: Connection failed (OS Error: Network is unreachable, errno = 101), address = 8.8.4.4, port = 53)
SocketException (SocketException: Connection failed (OS Error: Network is unreachable, errno = 101), address = 208.67.222.222, port = 53)

Hello,
Please take into account that in Flutter 1.22 next breaking change is coming, so please consider about applying next changes:
https://flutter.dev/docs/release/breaking-changes/network-policy-ios-android

In current version it will never pass Apple AppStore app approval process, because it does not work in IPv6 network. I wasted few days because of it.

I used it to check the internet connection during the testing, I noticed that It shows "don't have internet connection while I have it over sim card".
Android Phone

Hi, Is this plugin still in Beta? are there any plans to keep this plugin up to date?

The connectivity package does not support native dart.

Can you add the option to check if the device have network? (internet DataConnectionChecker will stay the same).

It will be very helpful to have something like DataConnectionChecker().onStatusChange.listen( but for the network connection only.

DataConnectionChecker().onStatusChange.listen always returns 'DataConnectionStatus.disconnected ' status when the application is in the background.

It's still returning true even if my wifi has not active internet connection..

bool result = await DataConnectionChecker().hasConnection;
if(result == true) {
print('YAY! Free cute dog pics!');
} else {
print('No internet :( Reason:');
print(DataConnectionChecker().lastTryResults);
}