Heartbeater is disabled by default although doc says the opposite about fluency HOT 5 CLOSED

TCPSender doesn't use any heartbeat by default. But if you set up a Fluency using Fluency.defaultFluency(List<InetSocketAddress> servers, Config config), TCPSender uses TCPHeartbeater internally for quick failover.

from fluency.

Is it an issue now or not?

If so - is this the correct way to activate the Heartbeat:

Instantiator heartbeaterConfig = new TCPHeartbeater.Config().setHost(serverIp).setPort(serverPort);

Config senderConfig = new TCPSender.Config().setHost(serverIp).setPort(serverPort).setHeartbeaterConfig(heartbeaterConfig);

RetryableSender retryableSender = new RetryableSender.Config(senderConfig).createInstance();

Fluency logger = new Fluency.Builder(retryableSender).build();

from fluency.

What also looks strange is the Heartbeat implementation itself:
org.komamitsu.fluency.sender.heartbeat.TCPHeartbeater.invoke()
Why are you opening and closing a SocketChannel? This operation is very expensive, instead of just activating a keep-alive.

from fluency.

@jondoe1337

Is it an issue now or not?

I don't think it's an issue. But if you want to use a heartbeat even when using only one Fluentd, the way you wrote to construct a Fluency instance should work. Maybe I'd better make org.komamitsu.fluency.Fluency#defaultFluency(host, port) use a heartbeat.

Why are you opening and closing a SocketChannel? This operation is very expensive

It's the same way as Fluentd's out_forward plugin. How much is it expensive at 1 sec interval comparing to TCP keep alive?

from fluency.

Okay, you are right - I might have used it the wrong way.

from fluency.