Provide an additional way to configure the RecordFormatter when using the FluencyBuilderForFluentd about fluency HOT 4 CLOSED

Perfect. If I drop a PR, would it be possible to have a 2.6.1 release soon?
Thanks a lot.

from fluency.

@frosiere Even with setRecordFormatter(), it looks still a bit complicated to inject Jackson modules. And I have another concern that a wrong RecordFormatter can be passed (e.g. passing JsonlRecordFormatter to FluencyBuilderForFluentd.)

How about this?

public class CustomFluencyLogbackAppender extends FluencyLogbackAppender<ILoggingEvent> {

    @Override
    protected FluencyBuilderForFluentd configureFluency() {
        final var builder = new FluencyBuilderForFluentd();
        // "setJacksonModulesForRecordFormatter" is too verbose...?
        builder.setJacksonModulesForRecordFormatter(Lists.newArrayList(
            new Jdk8Module(),
            new JavaTimeModule()
        ));
        return builder;
    }
}

from fluency.

Good point, proposal is nice and prevents using a wrong formatter. So, this may be the way to go.

An alternative would either be a method taking the FluentdRecordFormatter like
builder.setRecordFormatter(FluentdRecordFormatter formatter)
Or a method taking the record formatter config like
builder.setRecordFormatterConfig(RecordFormatter.Config config)
This would support possible extensions of the config in future releases.

From a more general point of view, only the solution exposing the formatter gives a way to "setup" (enable/disable feature, etc) the internal ObjectMapper by overriding the method AbstractRecordFormatter#registerObjectMapperModules.

Thanks a lot for your reply.

from fluency.

Yeah, setRecordFormatter() is more powerful. I'll go with it.
I'm a bit busy these days and it would take some time until the feature is released.

from fluency.