kolomiichenko / graylog-api Goto Github PK

When ever I execute the call for single message, I give new id but it still keeps the old id and execute http request according to the old id.

On index.js there is a callback that is done inside a try catch:

try {
    callback(null, JSON.parse(body));
} catch (err) {
    callback(["Bad response", err, reqUri]);
}

This is a bad practice and should be changed. Imagine that the code inside that callback has some bug and raises an exception. That exception will be caught on that catch block and callback is going to be called again, causing an error of the type Callback was already called. This is also effectively hiding the underneath error, making it hard to find out what the issue is and fix it.

I suggest it should be changed to something like:

var parsedBody;
try {
    parsedBody = JSON.parse(body);
} catch (err) {
    callback(["Bad response", err, reqUri]);
}

callback(null, parsedBody);

Version 1.2.0 breaks everything, no config options are used and no URI is built to form proper paths.

// Old Version
var Api = function(config) {
  this._protocol = config.protocol || 'http'; // or https
  this._auth = (config.basicAuth) ? buildBasicAuthHeader(config.basicAuth) : '';
  this._host = config.host || 'localhost';
  this._port = config.port || '12900';
  this._path = config.path || '';
  this._uri = this._protocol + '://' + this._host + ':' + this._port + this._path;
};

// New Version
var Api = function(config) {
  this._uri = this.uri;
};

This is due to changing mPath and reusing it. (see index.js:28)

I've worked around it by recording the original mPath and setting it back after issuing the request.

We have launched the beta of the Graylog Marketplace: https://marketplace.graylog.org/

The Marketplace is the central directory of all Graylog add-ons and integrations, including GELF libraries.

You would help us a lot if you could submit your library there. :)