Please add support for PVR_RECORDING.iChannelUid. Although PVR Addon API declares this property as optional, some Kodi features cannot work if the channel uid is not given with a recording, namely the "red dot" indicating an in-progress recording in pvr recordings window and recently recorded home screen widget, the right context menu entries for recordings in progess, maybe others.

Unfortunately, there is no reliable fix in Kodi possible without an PVR addon API change (which I plan for Kodi v19, btw.).

Thus, I kindly ask the maintainer of this addon to add support for PVR_RECORDING.iChannelUid so we can fix this issues for Kodi v18.

Thanks.

Output:

tvrpc.cpp:30:0:
/home/desktop/build-kodi-pvr-argustv-temp/kodi-pvr-argustv/src/pvrclient-argustv.h:62:85: warning: converting to non-pointer type ‘long int’ from NULL [-Wconversion-null]
   PVR_ERROR GetEpg(ADDON_HANDLE handle, const PVR_CHANNEL &channel, time_t iStart = NULL, time_t iEnd = NULL);
                                                                                     ^
/home/desktop/build-kodi-pvr-argustv-temp/kodi-pvr-argustv/src/pvrclient-argustv.h:62:105: warning: converting to non-pointer type ‘long int’ from NULL [-Wconversion-null]
   PVR_ERROR GetEpg(ADDON_HANDLE handle, const PVR_CHANNEL &channel, time_t iStart = NULL, time_t iEnd = NULL);
                                                                                                         ^
[ 35%] Building CXX object CMakeFiles/pvr.argustv.dir/src/channel.cpp.o
/usr/bin/c++   -DBUILD_KODI_ADDON -DTARGET_LINUX -DTARGET_POSIX -D_LINUX -Dpvr_argustv_EXPORTS -I/usr/include/kodi -I/usr/include/platform -I/home/desktop/build-kodi-pvr-argustv-temp/kodi-pvr-argustv/src -I/usr/include/jsoncpp  -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -D_FORTIFY_SOURCE=2 -std=gnu++11 -flto -fPIC -O3 -DNDEBUG -fPIC   -o CMakeFiles/pvr.argustv.dir/src/channel.cpp.o -c /home/desktop/build-kodi-pvr-argustv-temp/kodi-pvr-argustv/src/channel.cpp
[ 40%] Building CXX object CMakeFiles/pvr.argustv.dir/src/client.cpp.o
/usr/bin/c++   -DBUILD_KODI_ADDON -DTARGET_LINUX -DTARGET_POSIX -D_LINUX -Dpvr_argustv_EXPORTS -I/usr/include/kodi -I/usr/include/platform -I/home/desktop/build-kodi-pvr-argustv-temp/kodi-pvr-argustv/src -I/usr/include/jsoncpp  -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -D_FORTIFY_SOURCE=2 -std=gnu++11 -flto -fPIC -O3 -DNDEBUG -fPIC   -o CMakeFiles/pvr.argustv.dir/src/client.cpp.o -c /home/desktop/build-kodi-pvr-argustv-temp/kodi-pvr-argustv/src/client.cpp
In file included from /home/desktop/build-kodi-pvr-argustv-temp/kodi-pvr-argustv/src/client.cpp:22:0:
/home/desktop/build-kodi-pvr-argustv-temp/kodi-pvr-argustv/src/pvrclient-argustv.h:62:85: warning: converting to non-pointer type ‘long int’ from NULL [-Wconversion-null]
   PVR_ERROR GetEpg(ADDON_HANDLE handle, const PVR_CHANNEL &channel, time_t iStart = NULL, time_t iEnd = NULL);
                                                                                     ^
/home/desktop/build-kodi-pvr-argustv-temp/kodi-pvr-argustv/src/pvrclient-argustv.h:62:105: warning: converting to non-pointer type ‘long int’ from NULL [-Wconversion-null]
   PVR_ERROR GetEpg(ADDON_HANDLE handle, const PVR_CHANNEL &channel, time_t iStart = NULL, time_t iEnd = NULL);
                                                                                                         ^
/home/desktop/build-kodi-pvr-argustv-temp/kodi-pvr-argustv/src/client.cpp: In function ‘PVR_ERROR GetAddonCapabilities(PVR_ADDON_CAPABILITIES*)’:
/home/desktop/build-kodi-pvr-argustv-temp/kodi-pvr-argustv/src/client.cpp:352:18: error: ‘PVR_ADDON_CAPABILITIES’ has no member named ‘bSupportsRecordingFolders’
   pCapabilities->bSupportsRecordingFolders   = true;
                  ^
CMakeFiles/pvr.argustv.dir/build.make:137: recipe for target 'CMakeFiles/pvr.argustv.dir/src/client.cpp.o' failed
make[3]: *** [CMakeFiles/pvr.argustv.dir/src/client.cpp.o] Error 1
make[3]: Leaving directory '/home/desktop/build-kodi-pvr-argustv-temp/kodi-pvr-argustv/obj-x86_64-linux-gnu'
CMakeFiles/Makefile2:102: recipe for target 'CMakeFiles/pvr.argustv.dir/all' failed
make[2]: *** [CMakeFiles/pvr.argustv.dir/all] Error 2
make[2]: Leaving directory '/home/desktop/build-kodi-pvr-argustv-temp/kodi-pvr-argustv/obj-x86_64-linux-gnu'
Makefile:152: recipe for target 'all' failed
make[1]: *** [all] Error 2
make[1]: Leaving directory '/home/desktop/build-kodi-pvr-argustv-temp/kodi-pvr-argustv/obj-x86_64-linux-gnu'
dh_auto_build: make -j1 returned exit code 2
debian/rules:13: recipe for target 'build' failed
make: *** [build] Error 2
dpkg-buildpackage: error: debian/rules build gave error exit status 2

Hi,
The Isengard branch fail to build with gcc 5.2.1 and arches different than i386 or amd64 (armhf, powerpc, armel)

src/uri.cpp:44:3: error: narrowing conversion of ‘(uri::char_class_e)-2’ from ‘int’ to ‘char’ inside { } [-Wnarrowing]
src/uri.cpp:65:3: error: narrowing conversion of ‘(uri::char_class_e)-2’ from ‘int’ to ‘char’ inside { } [-Wnarrowing]
src/uri.cpp:86:3: error: narrowing conversion of ‘(uri::char_class_e)-2’ from ‘int’ to ‘char’ inside { } [-Wnarrowing]
src/uri.cpp:107:3: error: narrowing conversion of ‘(uri::char_class_e)-2’ from ‘int’ to ‘char’ inside { } [-Wnarrowing]
src/uri.cpp:128:3: error: narrowing conversion of ‘(uri::char_class_e)-2’ from ‘int’ to ‘char’ inside { } [-Wnarrowing]

In src/pvrclient-argustv.h GetEpg() definition set iStart and iEnd default to NULL.
But time_t is a long value and cannot be set to NULL.
Since those args are provided, we can simply remove the default value.

Hi,

I'm just wondering if there is (or will be) a work ongoing to make pvr.argustv compatible with Kodi 18. The actaul nightly version of Kodi does not include the pvr for ArgusTV (check this thread on the Kodi forum).

Thanks in advance for any feedback.

Alex

I am using v2.2.1 which is the last version I can use on WHS (windows 2003 server), 32 bit.
Latest kodi update broke the Argus client - seems "keep alive" is not working.
Kodi log shows:
16:37:20.641 T:2652 ERROR: CCurlFile::FillBuffer - Failed: HTTP returned error 500
16:37:20.642 T:2652 ERROR: CCurlFile::Open failed with code 500 for http://192.168.1.6:49943/ArgusTV/Control/GetLiveStreamTuningDetails:
16:37:20.642 T:2652 ERROR: AddOnLog: ARGUS TV client: can not write to http://192.168.1.6:49943/ArgusTV/Control/GetLiveStreamTuningDetails
16:37:25.067 T:10476 ERROR: CCurlFile::FillBuffer - Failed: HTTP returned error 500
16:37:25.067 T:10476 ERROR: CCurlFile::Open failed with code 500 for http://192.168.1.6:49943/ArgusTV/Control/KeepLiveStreamAlive:
16:37:25.067 T:10476 ERROR: AddOnLog: ARGUS TV client: can not write to http://192.168.1.6:49943/ArgusTV/Control/KeepLiveStreamAlive
16:37:26.167 T:2652 ERROR: CCurlFile::FillBuffer - Failed: HTTP returned error 500
16:37:26.167 T:2652 ERROR: CCurlFile::Open failed with code 500 for http://192.168.1.6:49943/ArgusTV/Control/GetLiveStreamTuningDetails:
16:37:26.167 T:2652 ERROR: AddOnLog: ARGUS TV client: can not write to http://192.168.1.6:49943/ArgusTV/Control/GetLiveStreamTuningDetails
16:37:31.697 T:2652 ERROR: CCurlFile::FillBuffer - Failed: HTTP returned error 500
16:37:31.697 T:2652 ERROR: CCurlFile::Open failed with code 500 for http://192.168.1.6:49943/ArgusTV/Control/GetLiveStreamTuningDetails:
16:37:31.697 T:2652 ERROR: AddOnLog: ARGUS TV client: can not write to http://192.168.1.6:49943/ArgusTV/Control/GetLiveStreamTuningDetails
16:37:35.149 T:10476 ERROR: CCurlFile::FillBuffer - Failed: HTTP returned error 500

etc...

https://github.com/kodi-pvr/pvr.argustv/blob/master/FindJsonCpp.cmake#L3 doesn't work

-- Checking for module 'jsoncpp'
--   Found jsoncpp, version 1.7.2
CMake Error at /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:148 (message):
  Could NOT find JsonCpp (missing: JSONCPP_INCLUDE_DIRS)

rpm -ql jsoncpp-devel

/usr/include/json
/usr/include/json/allocator.h
/usr/include/json/assertions.h
/usr/include/json/autolink.h
/usr/include/json/config.h
/usr/include/json/features.h
/usr/include/json/forwards.h
/usr/include/json/json.h
/usr/include/json/reader.h
/usr/include/json/value.h
/usr/include/json/version.h
/usr/include/json/writer.h
/usr/lib64/cmake
/usr/lib64/cmake/jsoncpp
/usr/lib64/cmake/jsoncpp/jsoncppConfig-release.cmake
/usr/lib64/cmake/jsoncpp/jsoncppConfig.cmake
/usr/lib64/libjsoncpp.so
/usr/lib64/pkgconfig/jsoncpp.pc
/usr/share/doc/jsoncpp
/usr/share/doc/jsoncpp/NEWS.txt

we got new files

/usr/lib64/cmake/jsoncpp/jsoncppConfig-release.cmake
/usr/lib64/cmake/jsoncpp/jsoncppConfig.cmake

cat /usr/lib64/pkgconfig/jsoncpp.pc

prefix=/usr
exec_prefix=${prefix}
libdir=/usr/lib64
includedir=/usr/include

Name: jsoncpp
Description: A C++ library for interacting with JSON
Version: 1.7.2
URL: https://github.com/open-source-parsers/jsoncpp
Libs: -L${libdir} -ljsoncpp
Cflags: -I${includedir}

using :
pkg_check_modules (JSONCPP json)
works, by I don't understand why it works , but pass the missing: JSONCPP_INCLUDE_DIRS

xbmc/xbmc#9621 (comment)

Hi All,
Just to notify that when Kodi 17 exits and the ArgusTV Client is activated, there is a crash. I have activated the bebug (please refer to the attachment for the complete log). It seems that there are some issues while releasing the add-on.
Hope you can provide fix. Thanks for your effort in advance.

kodi_bug.log.txt

Hey there,

first of all thanks for your great work!!

Now I have updated my raspberry pi 3 from Kodi 17 to 18 running libreelec.
There I have got the issue that I cant skip backward/forward in live TV.
Thats annoying if you paused live TV and you cant skip the advertising or you missed something and cant skip backward.
In Kodi 16 there wasn't such a problem and skipping worked well.
Also tested on Windows runnig testweise Kodi 18 and 19. Same issue.

Is there a chance to fix this or am I doing something wrong.

Thanks

Paul

It seems that Kodi on the NVidia Shield TV sends a Connection: Upgrade, HTTP2-Settings header even though the request is a POST.

Some servers barf on this as it seems to be an invalid request (most notable the Kestrel server in .NET Core: aspnet/KestrelHttpServer#2372)

It's not clear to me where it exactly goes wrong? a libcurl issue only on Android? Running Kodi 18.1 on Windows with the ARGUS TV plugin works fine with Kestrel in any case -- so it does seem to be related to the host OS.

Anyone with more in-depth knowledge in this that can comment?

Can you please create a release tag (looks like it should be "v3.0.1" based on the contents of https://github.com/kodi-pvr/pvr.argustv/blob/master/pvr.argustv/addon.xml.in )?

That would really help distributions (in my case, Gentoo) package this add-on.

Thanks!

Hi,
timeshift on live-tv is not working for a longer while now in Kodi 18.0. Is there any chance for a fix on that issue?
Best wishes

Clean install of 2018-11-13-raspbian-stretch-lite
Did an apt update/dist-upgrade
Installed kodi (2:18.0-1stretch) and kodi-pvr-argustv (3.5.4-1stretch)
Started kodi and configured pvr
Confirmed that TV guide loaded correctly
Clicked to play a channel, got the following error in the terminal...

/usr/lib/arm-linux-gnueabihf/kodi/kodi-rbpi: symbol lookup error: /usr/lib/arm-linux-gnueabihf/kodi/addons/pvr.argustv/pvr.argustv.so.3.5.4: undefined symbol: _ZN7ArgusTV9CTsReaderC1Ev

Also got the same with kodi-rbpi_v7