knjk04 / sortinghat Goto Github PK

The wrong house is sometimes attributed to each answer

Toggle sound does not work on the title screen. I think createBackgroundMusic() is being called if the sound button was muted, but stopMusic() isn't actually stopping the music if the sound button wasn't previously muted.

• Rotating the screen on the quiz screen:
  • starts the song again (it shouldn't)
  • only shows the answers that can fit. You can't scroll at all

Branch tested on: experimental (which is up to date with the feature branch)

Above (& in the case of the ResultsActivity class, it should resume the same song, not start a new one)

Better to use a standardised format than making one

The same methods are being used across different classes. Perhaps make a wrapper class for MediaPlayer?

Check MusicController class

Describe the bug
The intro music continues to play when you click on 'Begin'. Sometimes, it's fine and stops, but at other times it does not.

To Reproduce
Steps to reproduce the behaviour:

1. Open app
2. Click on 'Begin'
3. Hear the music

Expected behaviour
The intro music should stop playing when you click on begin.

Android version (please complete the following information):

• Device: Pixel XL
• OS: Android 9/P beta
• (Optional) API level: 28

(Optional) Where in code (if known)

• Branch: experimental and master
• File: MainActivity.java
• Method: stopMusic() ?
• Line number: 49?

Expected behaviour: you continue as normal (as you would if you hadn't rotated the screen - i.e. do not restart the quiz)

The app icon is being displayed on a Pixel simulator on Android Studio but not on my Pixel XL even after uninstalling and then reinstalling the app

The default app icon is being shown instead

I've added both Round and square icons (Pixel phones show round icons on stock launcher)

Update:

• Tested app on OnePlus One and the icon shows (I can get both round and square icons to appear when using Nova launcher)

Describe the bug
Music in QuizActivity does not stop when you switch to ResultsActivity

To Reproduce
Steps to reproduce the behaviour:

1. Click on begin
2. Go through all of the questions
3. Hear the piano music (bensound_memories) playing

Expected behaviour
The music from QuizActivity should stop when you switch to ResultsActivity

Screenshots
N/A

Android version (please complete the following information):

• Device: Pixel XL
• OS: Android 9/P
• (Optional) API level: 28

Additional context
N/A

(Optional) Where in code (if known)

• Branch (e.g. Feature): Feature
• File (e.g. QuizActivity.java): QuizActivity.java
• Method (e.g. in determineHouse()): stopMusic()?
• Line number (if known): N/A

On the title screen, if you fill our your first name and then rotate the screen, your name will no longer appear in the edittext field

Branch tested on: experimental (which is up to date with the feature branch)

Change README to .MD file from an org file since everything that I have there can be done (they're both markdown and having a .MD README is better in case anyone wants to contribute to the README, but isn't familiar with the Org Syntax)

The starting icon is correct -- it should be the muted icon because the background music is playing. If I click on the icon, it doesn't do anything (because it calls the else block in toggleSound() and isMuted is false by default. The setImageResources in toggleSound() probably just need to be swapped around (the one in the if clause should be in the else clause and visa versa)

This affects all of the Activity classes.

Looks fine on Nexus 4 simulator, but too small on an actual Pixel XL

Describe the bug
Cannot get house music to play at the position where it was last at before the activity was paused

To Reproduce
Steps to reproduce the behaviour:

1. Go through the quiz
2. Leave app when you get to the results screen
3. Return to the app
4. See error

Expected behaviour
The house music should continue at its last played position

Screenshots
N/A

Android version (please complete the following information):

• Device: Pixel XL
• OS: Android 8
• (Optional) API level: 28

Additional context
I can get the house music to replay from the beginning, but not from a particular moment in the song

(Optional) Where in code (if known)

• Branch (e.g. Feature): Feature
• File (e.g. QuizActivity.java): ResultsActivity.java
• Method (e.g. in determineHouse()): onResume()
• Line number (if known): 110-111