kni / redis-sharding-hs Goto Github PK

Hi!

It's me again. I think that it would be better to support lowercase commands just like the real redis client. Here is a patch that I created for your approval: https://gist.github.com/4689691

Thank you for developing redis-sharding-hs!

As I am performing my benchmarks on the proxy with the updated commits, I have noticed that there is around 20% decrease in the number of transaction per second on read operations. There is also an increased bandwidth usage (upload speed is now double the amount of the download speed used by the proxy, hence probably wasted bandwidth)

Maybe we should let TCP_NODELAY deactivated for good.

You might also want to read more about TCP_NODELAY's consequences here:
http://www.unixguide.net/network/socketfaq/2.16.shtml

Some clients might still be using an old version of redis clients (or only telnet and similar tools are available at their disposal) so it might be better if we support such feature.

I am currently working on adding some customizations on your base code for some (weird) internal purposes we do on our projects. However, reading Haskell code wasn't that easy and comments would really help.

But github seems to incorrectly encode Cyrillic (I guess) on commits that defeats the purpose of putting the comments on the code.

Is there a way to render the comments properly? I tried redecoding the files but it was futile as the characters never rendered properly on Cyrillic Windows and Macintosh formats. My terminal session is already on UTF-8 as well as my system.

Or if you have time, can you instead recomment them in English to eliminate the encoding problems altogether? (I am sorry for asking too much from you :( )