Code Monkey home page Code Monkey logo

Comments (10)

adrcunha avatar adrcunha commented on May 28, 2024

/assign @dushyanthsc

from test-infra.

knative-prow-robot avatar knative-prow-robot commented on May 28, 2024

@adrcunha: GitHub didn't allow me to assign the following users: dushyanthsc.

Note that only knative members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

/assign @dushyanthsc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

from test-infra.

dushyanthsc avatar dushyanthsc commented on May 28, 2024

/assign @dushyanthsc

from test-infra.

dushyanthsc avatar dushyanthsc commented on May 28, 2024

Commit adds Zipkin tracing support to test infrastructure. However, fundamental requirement of this feature is the availability of Monitoring components installed on the KNative cluster. Currently, monitoring is not enabled by default for e2e tests due to this which is blocked on Issue: #647

Till #647 is addressed, developers can enable Zipkin tracing for clusters setup with Monitoring using following instructions:

  1. Setup KNative cluster with Logging and Monitoring enabled.
  2. In the test-setup call Zipkin initializer.
  3. As recommended for e2e tests, use SpoofingClient to communicate with your KNative cluster.
  4. For the HTTP request that you would like to inspect Zipkin trace, call LogZipkinTrace()
  5. In the test-cleanup call Zipkin cleanup

As an example a sample commit enabling zipkin tracing is available in this repository.

from test-infra.

jessiezcc avatar jessiezcc commented on May 28, 2024

@dushyanthsc, can this issue be closed now?

from test-infra.

dushyanthsc avatar dushyanthsc commented on May 28, 2024

After talking to Adriano, we have decided to enable atleast Zipkin for E2E tests. I will work on this to enable Zipkin tracing. ETA at the moment is 02/22/2019

from test-infra.

adrcunha avatar adrcunha commented on May 28, 2024

@dushyanthsc isn't this one done already?

from test-infra.

dushyanthsc avatar dushyanthsc commented on May 28, 2024

I think this was picked up by @yt3liu and was completed.

from test-infra.

yt3liu avatar yt3liu commented on May 28, 2024

The previous change only enabled zipkin for performance test. Related issue: #539

That's done in this PR knative/serving#3594. Similar change can be done for all tests to enable zipkin.

from test-infra.

adrcunha avatar adrcunha commented on May 28, 2024

Thanks, closing.

from test-infra.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.