Comments (9)
Thanks for the write up and issue! I like the idea of us cloning /test-infra to /tools and /infra and archiving test-infra for history sake.
from test-infra.
I'd rather not move GitHub actions away from our knative/actions
repository - that's the central spot for reusable actions
from test-infra.
The idea is once infra is cleaned up and should only be hosting prow, terraform, etc we would think about bringing in actions there where we would still use reusables, but that would be probably later once we move more to actions and spin down our dependence on prow. Is there any big push back reason you would have for keeping actions separate at that point?
from test-infra.
@dprotaso If we move those actions, it would be just a minor change for consuming repos.
jobs:
test:
- uses: knative/actions/.github/workflows/go-test.yaml@main
+ uses: knative/infra/github/workflows/go-test.yaml@main
I think that's doable. Looks easy.
from test-infra.
Is there any big push back reason you would have for keeping actions separate at that point?
I just don't see the value of the churn - and you'll have to keep the old actions around for at least 6 months so you don't break release branches (or you update branches as well)
from test-infra.
If we decide to move the actions (for sure, that's for the future, not now), we'll definitely leave the old repo in place as a read-only archive.
Also, the old branches, should really be using actions from a specific release, not the tip. We know otherwise repos CI may be in a defunct state and will require manual revitalization, by aligning actions to previous, compatible versions.
from test-infra.
Also, the old branches, should really be using actions from a specific release, not the tip. We know otherwise repos CI may be in a defunct state and will require manual revitalization, by aligning actions to previous, compatible versions.
A big con to this approach is you could be building with older golang versions that could have a CVE
from test-infra.
This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen
. Mark the issue as
fresh by adding the comment /remove-lifecycle stale
.
from test-infra.
basically done
from test-infra.
Related Issues (20)
- [EPIC] Prow to Github Actions migration plan HOT 3
- s390x: run perodic e2e tests in 'short' mode HOT 1
- Notarise our binaries for Mac HOT 1
- Migrate away from CNCF for Knative, 01DDAC-7D2015-6E152D GCP Billing Account HOT 2
- Downgrade / Suspend Google Workspace accounts of contributors no longer contributing HOT 3
- Add Taylor Wagonner (LF) as a knative.dev Google Workspace SuperAdmin HOT 2
- The `tools/go-ls-tags/files.ReadLines` always reads just first line
- Image Signing Status HOT 1
- Safe-settings for peribolos investigation HOT 3
- Auto-cleanup inactive members HOT 7
- Drop infrastructure support for 1.5 jobs HOT 2
- Investigate GitHub generated release notes HOT 3
- Automate buming golang patch versions
- Update deps jobs failing
- EasyCLA and Tide (from Slack) HOT 1
- remove old CNCF task force from community HOT 4
- Reviewers not being assigned by prow HOT 6
- Spin down 1.7 jobs HOT 6
- Bumping dependencies should not break our tools HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from test-infra.