Comments (6)
cc @adrcunha
cc @jessiezcc
cc @evankanderson
from test-infra.
from test-infra.
For auto-generated files, we can flag the file with coverage-excluded so that code coverage will ignore it. see below for an example
/pkg//testing/ coverage-excluded=true
from test-infra.
Do we really want to include the data from source files without corresponding _test.go? I think our consensus was to ignore them
In terms of reporting, what do you think the report would look like if we are to include those files? @srinivashegde86
from test-infra.
the tool should be smart enough to include coverage report of files without test files. If we expect there to be test files for every file needing coverage, we should explicitly state that:
- Files with no corresponding *_test.go will not be included in the coverage report.
- Add a presumbmit check to make sure that all *.go files either have a *_test.go file or the coverage-ignore gitattribute. This check will be repo-specific and not at this tool's discretion though.
from test-infra.
fixed by the last two commits here: https://github.com/steuhs/test-infra/commits/re-org
from test-infra.
Related Issues (20)
- s390x: run perodic e2e tests in 'short' mode HOT 1
- Notarise our binaries for Mac HOT 1
- Migrate away from CNCF for Knative, 01DDAC-7D2015-6E152D GCP Billing Account HOT 2
- Downgrade / Suspend Google Workspace accounts of contributors no longer contributing HOT 3
- Add Taylor Wagonner (LF) as a knative.dev Google Workspace SuperAdmin HOT 2
- The `tools/go-ls-tags/files.ReadLines` always reads just first line
- Image Signing Status HOT 1
- Safe-settings for peribolos investigation HOT 3
- Auto-cleanup inactive members HOT 7
- Drop infrastructure support for 1.5 jobs HOT 2
- Investigate GitHub generated release notes HOT 3
- Automate buming golang patch versions
- RabbitMQ doesn't show in the prow dropdown filter HOT 4
- Update deps jobs failing
- EasyCLA and Tide (from Slack) HOT 1
- remove old CNCF task force from community HOT 4
- Reviewers not being assigned by prow HOT 6
- Split `test-infra` repo into `tools` and `infra` repos HOT 9
- Spin down 1.7 jobs HOT 6
- Bumping dependencies should not break our tools HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from test-infra.