Code Monkey home page Code Monkey logo

Comments (6)

srinivashegde86 avatar srinivashegde86 commented on June 7, 2024

cc @adrcunha
cc @jessiezcc
cc @evankanderson

from test-infra.

evankanderson avatar evankanderson commented on June 7, 2024

from test-infra.

jessiezcc avatar jessiezcc commented on June 7, 2024

For auto-generated files, we can flag the file with coverage-excluded so that code coverage will ignore it. see below for an example
/pkg//testing/ coverage-excluded=true

from test-infra.

steuhs avatar steuhs commented on June 7, 2024

Do we really want to include the data from source files without corresponding _test.go? I think our consensus was to ignore them
In terms of reporting, what do you think the report would look like if we are to include those files? @srinivashegde86

from test-infra.

srinivashegde86 avatar srinivashegde86 commented on June 7, 2024

the tool should be smart enough to include coverage report of files without test files. If we expect there to be test files for every file needing coverage, we should explicitly state that:

  1. Files with no corresponding *_test.go will not be included in the coverage report.
  2. Add a presumbmit check to make sure that all *.go files either have a *_test.go file or the coverage-ignore gitattribute. This check will be repo-specific and not at this tool's discretion though.

from test-infra.

steuhs avatar steuhs commented on June 7, 2024

fixed by the last two commits here: https://github.com/steuhs/test-infra/commits/re-org

from test-infra.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.