kloudless / kloudless-node Goto Github PK

I use

• Node 10.14.1
• NPM 6.4.1

There is such message:

npm install kloudless
npm WARN deprecated [email protected]: Use uuid module instead
npm WARN deprecated [email protected]: The major version is no longer supported. Please update to 4.x or newer
+ [email protected]
updated 1 package and audited 22475 packages in 13.078s
found 8 moderate severity vulnerabilities

So we have two deprecated package and 8 possible vulnerabilities.

I upgraded to Node 0.12.6, and begun getting the following error on the first request to Kloudless web api:

throw new TypeError('msecs must be a number');
      ^

TypeError: msecs must be a number
at Object.exports.enroll (timers.js:165:11)
at TLSSocket.Socket.setTimeout (net.js:337:12)
at ClientRequest. (_http_client.js:565:10)
at ClientRequest.g (events.js:199:16)
at ClientRequest.emit (events.js:129:20)
at tickOnSocket (_http_client.js:493:7)
at _http_client.js:504:7
at process._tickDomainCallback (node.js:381:11)

After investigation, it seems there was a default value on the msec parameter of the setTimeout function on the previous version of node (0.10), which has disappeared.

I fixed this temporarily on line 21 of kloudless.js (added the timeout property):

this._api = {
    auth: null,
    protocol: Kloudless.defaultConfig.protocol,
    host: Kloudless.defaultConfig.host,
    port: Kloudless.defaultConfig.port,
    ca: null,
    basePath: Kloudless.defaultConfig.basePath,
    timeout: 2000
};

Could we get a better fix ?

Could we add typescript definition for the package?

The message I get is:
Error uploading file: Error: Request failed: name and parent_id must be strings representing the name of the new file and ID of the pa
rent folder object respectively. url must be the URL to upload the file from.

The code we use is:
kloudless.files.upload({
"name": "test.docx",
"account_id": accountId,
"parent_id": "Fp7u6cdR6tt3njEN3j4Cya3NJsaltoX3SwxA5-opkWm0=",
"file": filestream,
// all API calls can specify URL query parameters by defining "queryParams"
"queryParams": {
"overwrite": "true"
}
followed with error handling.

I'm using kloudless.files.contents to get a download stream and pipe it to S3, but the output files in S3 are corrupt. The same issue can be seen when piping the stream to a local file. For example, when I download a jpg, the output file is corrupt:

kloudless.files.contents({
  account_id: [account_id],
  file_id: [file_id]
}, (err, stream) => {
  if(err){
    console.log(err);
  } else {
    var output = require('fs').createWriteStream('./output.jpg');
    stream.pipe(output);
  }
});

I can fix the issue by removing the line res.setEncoding('binary'); in lib/resources.js (https://github.com/Kloudless/kloudless-node/blob/master/lib/resources.js#L44) and the files download properly, but I'm not sure what other consequences there may be to that. Do you think this fix is appropriate?

The doc about folders.create() states a 'folder_id' paramter. This creates the folder systematically in the root folder of the cloud storage.
Should be 'parent_id' (tested, and works for me)

No big deal, though :-)