events that hook choose() and close() would be nice about file-picker HOT 9 CLOSED

Hi @lutherism . I might be misunderstanding, but wouldn't the current cancel and success event handlers be sufficient to close the shadow frame in? They are invoked when the modal is closed.

In addition, if you are calling choose() via JS, you can open the shadow frame before/after the call. If you are using choosify, just set a click handler on the element passed in to choosify to open the shadow frame instead.

Does this work?

from file-picker.

Thanks for the quick response :D.

Do you have a link to the 'close' event? There doesn't seem to be a 'close' event. We have put our UI cleanup in three events: 'cancel', 'success', and 'error', to cover all the close states we could find.

from file-picker.

Apologies I meant cancel instead of close. Edited my post above to reflect the correction. That is correct that there are three events you would want to catch to do cleanup in. I'll look into adding a separate close event to always trigger regardless of the reason for closing.

from file-picker.

Thanks. Yea adding that consistent event will make our code a lot easier to maintain.

from file-picker.

As for the choose hook, you're right it's not as necessary. But it would allow us to be less concerned with when/where we call explorer.choose();

IE, a page could create an explorer instance, then any number of subviews could call explorer.choose() without having to know the specifics of what the page wants to do in response.

from file-picker.

Whoops, accidentally closed. I always mistake that button for the Cancel button.

Adding open, close events.

from file-picker.

Added in 3a70c56. This will be released within the week.

from file-picker.

Brilliant. Thanks.

from file-picker.

This has been released.

from file-picker.