klobuczek / active_node Goto Github PK

Would anyone be interested in connection pooling? If I'm understanding the Neo class correctly, each time Neo.db is called it creates a new connection. I've got connection pooling working in my branch, should I send a pull request?

https://github.com/chrisgogreen/active_node

I added some readme to my branch for using the connection pool.
I wrapped @db in an if else to check for a globally defined db connection.

module ActiveNode
  class Neo
    def self.db
     if defined? $db
     @db = $db
     else
     @db ||= Neography::Rest.new
     end
    end
  end
end

If you define $db when your application initializes you can use a configurable connection pool:

require 'connection_pool'
$db = ConnectionPool::Wrapper.new(size: 50, timeout: 15) { Neography::Rest.new }

I'm not sure if using a global is a good idea in this case, but it got me loading data much faster last night. Before I made this change my sidekiq workers were loading about 20 nodes per second(one node per job), right now they are loading about 100.

Maybe instead of checking if a global named $db is defined I could check if any instances of the ConnectionPool class exist?

Is this ready to go? Any hello world examples?

I'd like to be able to create_or_update? I see some code for it but I can't tell how to use it and I don't see it in the specs. Is anyone creating_or_update 'ing?

Here for example, label is not existing on neo4j 1.9.* and so we are hiting exception cause the endpoint label is not existing.

Client Side

node = User.create! name: 'name' is hiting :

Neography::NeographyError: Neography::NeographyError
from /Users/kwent/.rvm/gems/ruby-2.1.2@down-node/gems/neography-     1.5.0/lib/neography/connection.rb:244:in `raise_errors'
from /Users/kwent/.rvm/gems/ruby-2.1.2@down-node/gems/neography-    1.5.0/lib/neography/connection.rb:217:in `handle_4xx_500_response'

Server Side

com.sun.jersey.api.NotFoundException: null for uri: http://localhost:7474/db/data/node/1/labels
    at com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1470)
    at com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1400)
    at com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1349)

When you try to fetch nodes using association macros (i.e :has_many) it returns simple Array class instead of ActiveNode::Graph.
This way methods cannot be chained further (i.e :order, :includes etc).