klest94 / bellatrex Goto Github PK

Hi there !

I tried to follow the instructions given in the README.md file for testing the module, but it failed right from the start with the following error:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "<string>", line 7, in <module>
ModuleNotFoundError: No module named 'utilities'

The problematic lines seem to be these ones:

I guess that this part of README.md was never updated since 69351d0.
My intent is just to bring it to your attention, as tutorial.ipynb seems the be the new correct way to follow the tutorial (although that is nowhere mentioned).

Cheers,
Weis

Following up on #3, I tried to run the tutorial provided in the tutorial.ipynb Jupyter Notebook. I was able to follow it successfully until the very last cell, that unfortunately crashes when executed. It gives me the following exception:

---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
Cell In[8], line 11
      7 preds_distr = np.load("example-data/bin_tutorial_y_train_preds.npy")
      8 axs = plot_rules(rules, preds, baselines, weights, 
      9             max_rulelen=None, other_preds=other_preds, preds_distr=preds_distr,
     10 )
---> 11 axs[0].set_xlim([0,1])
     12 # plt.savefig("visualisation.pdf")

AttributeError: 'numpy.ndarray' object has no attribute 'set_xlim'

As indicated, the error seems to be that the axs variable is treated as an array of matplotlib.axes.Axes, whereas it is actually an array of array of matplotlib.axes.Axes. I guess the problem comes from 1ff6da6, where the following change occurred in visualisation.py (around line 199):

-    return axs
+    return aaxs

Replacing axs[0] with axs[0, 0] in the tutorial fixed the issue and successfully plotted a graph. I'm not sure if it's the tutorial that needs to be updated or the value returned by the plot_rules function.

Cheers,
Weis