klarna / remote-frames Goto Github PK

Actual behaviour:
Currently <WrapperComponent> https://github.com/klarna/remote-frames/blob/master/src/RemoteFramesProvider.js#L80 doesn't support props.

Requested behaviour:
Add wrapperComponentProps alongside with existing wrapperComponent. Make sure to make changes to componentDidUpdate https://github.com/klarna/remote-frames/blob/master/src/RemoteFramesProvider.js#L50 to call renderGlobalTarget when wrapperComponentProps changes.

Hi frontend team @klarna!

I stumbled upon this project and it striked me with the conceptual similarity to already existing (and now official) React's Portals: https://reactjs.org/docs/portals.html. Now I did skim through the readme but I miss a good summary of how this project is different/better to the original React's Portals. Can you explain that, even in the answer to this issue? Or maybe what was your initial motivation to create this project. Just curious (and perhaps not only me) about React, JS and frames/widgets just like your checkout widget.

Cheers!