kjvalencik / ghshare Goto Github PK

Many of the errors are the raw stack trace or OpenSSL error.

Config file can store parameters and make commands simpler:

• Token
• Github Enterprise Host
• Key

For small data (e.g., 117 bytes with PKCS#1) it can be convenient to encrypt the data without an envelope so that it can be decrypted with OpenSSL. This can provide an easy flow for fetching public keys without forcing the recipient to download the client.

Refactor prompting for passphrases to be at the top level of the application. This will make testing easier and allow for alternate ways to provide values (e.g., config file).

• What you would encrypt
• Encrypting small and large files
• Command commands
• Github Enterprise use

Starting with Mojave, private keys are stored in OpenSSH format instead of RSA by default.

This should likely include a refactor to move prompting for accounts to the top level of the program. It is cleaner to handle this at the application level and leave the functionality to simple Option arguments.

Grabbing keys from public github no longer requires an API token. Attempt to grab without credentials before prompting the user.

Currently, an encrypted file will never end with a message that is exactly the chunk size. If it matches exactly, it will create a new empty message that only contains the tag.

This simplifies reading because it does not require any buffering to detect that we are on the last block. However, it may not match other stream implementations. One way to solve this is to keep a buffer that is double in size and modulus between the two halves. However, this significantly increases code complexity.

• 4-byte header length prefix
• Variable length protobuf encoded header
• Variable length header includes encrypted AES keys
• No delimiter between header and data
• Data has an unknown length
• AES-256-SIV

This code assumes any OpenSSL error reading the private key means that it has a passphrase. It should only check the specific code. This probably requires matching a string or unpacking the OpenSSL code.