kiwicommerce / magento2-inventory-log Goto Github PK

Hello, would you please tag a new version to include the most recent commits as a release? Thanks.

Preconditions

1. phpunit/phpunit 6.2.x
2. Magento 2.2.x

Steps to reproduce

1. Install Magento 2.2.x
2. Install the module kiwicommerce/magento2-inventory-log
3. Run phpunit

Expected result

1. The unit tests of kiwicommerce/module-inventory-log should pass

Actual result

1. Erorr when running PHPunit:

PHP Fatal error:  Class 'PHPUnit_Framework_TestCase' not found in vendor/kiwicommerce/module-inventory-log/Test/Unit/Helper/DataTest.php on line 16

The unit tests aren't updated to work with the PHP unit version used with Magento 2.2.

Title

Creating a credit nota with deleted products will give an error

Preconditions

1. Have the extension installed.
2. Pretty sure it doesn't work everywhere, but my Magento version is 2.3.2.

Steps to reproduce

1. Make an order with x and y product.
2. Delete x product and keep y product intact.
3. Create a credit nota of the order you just placed.

Expected result

1. A credit nota is created and the product that doesn't exist anymore is ignored and not looked at.

Actual result

1. It shows an error about the product that can't be found.

[2020-07-28 11:42:19] main.CRITICAL: The product that was requested doesn't exist. Verify the product and try again. {"exception":"[object] (Magento\\Framework\\Exception\\NoSuchEntityException(code: 0): The product that was requested doesn't exist. Verify the product and try again. at /vendor/magento/module-catalog/Model/ProductRepository.php:310)"} []

Thanks for your amazing modules, they really help a lot and are very well coded.

In the admin log module we can revert an action, I wonder if it is possible to include this status in the inventory log that the action was reverted by your module.

To reproduce this issue you have to set index to schedule mode:

php bin/magento indexer:set-mode schedule

Originally posted by @simonemonterubbiano in #3 (comment)

Hello,
I have just installed the ext on my magento 2.2.6. It seems only log my manual changes of stock qty. When I create an order from Admin, then complete the order, there's nothing logged. I'm using Flat Catalog.

When I exec:
php bin/magento setup:upgrade

Console returns:
SQLSTATE[42000]: Syntax error or access violation: 1235 This version of MariaDB doesn't yet support 'multiple triggers with the same action time and event for one table', query was: CREATE TRIGGER stock_after_insert AFTER INSERT ON cataloginventory_stock_item FOR EACH ROW
BEGIN
DECLARE isEnable SMALLINT(5);
SELECT 1 INTO isEnable FROM core_config_data WHERE path = 'inventory_log/general/inventory_enabled' and value = 1;
IF (isEnable = 1) THEN
IF (NEW.qty IS NOT NULL) THEN
IF (NEW.ukey IS NULL) THEN
INSERT INTO kiwicommerce_stock_movement(stock_item_id,product_id,current_qty,qty_movement,old_qty,is_in_stock,message,ukey) VALUES (NEW.item_id,NEW.product_id,NEW.qty,NEW.qty,0,NEW.is_in_stock,"Stock updated by direct query Insert",NEW.ukey);
END IF;
END IF;
END IF;
END

Inventory log config being disabled when other modules status changed

Preconditions

1. KiwiCommerce_InventoryLog installed and enabled
2. Store configuration for inventory log enabled

Steps to reproduce

1. In cli, disable a module (not KiwiCommerce_InventoryLog). e.g. php bin/magento Magento_Usps

Expected result

1. The store configuration for inventory log should not be affected or changed.

Actual result

1. The store configuration for inventory log is being disabled.