Comments (11)
I don't know where cookies are used in this theme, but I think the first easily solvable issue should be adding an option to Google Analytics to anonymize IPs @kitian616
from jekyll-text-theme.
So in order for a website to be GDPR compliant, aside from merging #63 there isn't really anything which should be done I the project itself. However I have a question(two actually). According to https://cookieconsent.insites.com (which I used for my banner) you need to add the banner before and I did so in the base.html layout, however nothing showed up. What am I doing wrong? Another thing is that GDPR requires cookie opt-ins and the possibility to revoke the consent, which means first load should disable all cookies, the above mentioned website gives a code block here but I have no idea where I should put it. Ideas?
from jekyll-text-theme.
Add code like this?
<link rel="stylesheet" type="text/css" href="//cdnjs.cloudflare.com/ajax/libs/cookieconsent2/3.0.3/cookieconsent.min.css" />
<script src="//cdnjs.cloudflare.com/ajax/libs/cookieconsent2/3.0.3/cookieconsent.min.js"></script>
<script>
window.addEventListener("load", function(){
...
});
</script>
If so, maybe because the load
event emitted before you use addEventListener
to bind the handler function.
from jekyll-text-theme.
Yea I managed to get the banner working, however for callback hook to actually block cookies, I have no clue. Any ideas?
from jekyll-text-theme.
You can just try to remove the addEventListener if you put this code at the bottom of the <body>
block, eg:
(function() {
...
})();
And also, you can use window.pageLoad
to handle the callback, even the load
event has been emitted, the callback would still working:
window.pageLoad.then(function() {
...
});
You can see the source here
from jekyll-text-theme.
So basically I should put this inside utils.js?
var type = this.options.type;
var didConsent = this.hasConsented();
if (type == 'opt-in' && didConsent) {
// enable cookies
}
if (type == 'opt-out' && !didConsent) {
// disable cookies
}
},
onStatusChange: function(status, chosenBefore) {
var type = this.options.type;
var didConsent = this.hasConsented();
if (type == 'opt-in' && didConsent) {
// enable cookies
}
if (type == 'opt-out' && !didConsent) {
// disable cookies
}
},
onRevokeChoice: function() {
var type = this.options.type;
if (type == 'opt-in') {
// disable cookies
}
if (type == 'opt-out') {
// enable cookies
}
},
Like I said I've no clue on this.
from jekyll-text-theme.
You can put it in utils.js, and you can also put it in common. https://github.com/kitian616/jekyll-TeXt-theme/blob/master/_includes/scripts/common.js
from jekyll-text-theme.
Mmm, how do I specify Disqus cookie? The only one that needs prior consent is Disqus if you set IP anonymization in google analytics.
from jekyll-text-theme.
Fixed the problem thank you! So long as #63 (the one in the comment tho) is merged this issue can be closed as it's the only one modification that truly needs to be added to the code itself.
from jekyll-text-theme.
errr.. why you want to specify Disqus cookie, something to do with the banner?
so it's almost May 25th, I'll merge it tonight.
from jekyll-text-theme.
Well you need to disable Disqus entirely until the users click "Agree" on the banner, and you also need to disable Disqus once again if the users ever revoke their choice. Welcome to EU Laws
from jekyll-text-theme.
Related Issues (20)
- Bug: Is MathJax 2.7.4 obsolete? It does not properly render equations anymore. HOT 5
- Site is down HOT 4
- 快速开始的链接挂了
- Feature request: mastodon support in social links
- Feature request: PWA支持?都9120年了,应该支持下PWA啊,然后最好还有个笔记功能
- Feature request: How config url and baseurl with github
- Bug: 安装错误 sass-embedded HOT 2
- Side-Menu Item Collapse
- Bug: [dev branch] A small typing error makes jekyll serve break down
- Feature request: Toggling between different skins
- Bug: ToC should be scrollable
- Feature request: sub-menus? HOT 1
- Feature request: Can jekyll encrypt articles like Hexo? Is it possible to add an article encryption function to the theme.
- Feature request:
- Feature request: Question: Text can support html in markdown ?
- Bug: Archive posts not showing up on mobile
- Feature request: callouts without border
- Bug: ffi gem not compatible anymore, icons not rendering HOT 1
- Bug: Mermaid labels were not displayed properly. HOT 2
- Nested list items not indented as is customary
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jekyll-text-theme.