Code Monkey home page Code Monkey logo

Comments (15)

HenryQW avatar HenryQW commented on July 23, 2024 2

simply because the system font has proper targeting for apple but not other OS.

https://github.com/kitian616/jekyll-TeXt-theme/blob/master/_sass/common/_variables.scss#L2

Those fonts are designed for Chinese.

And this is what I used to replace it, (GitHub style)

-apple-system, 
BlinkMacSystemFont, 
"Segoe UI",
Helvetica, 
Arial, 
sans-serif, 
"Apple Color Emoji", 
"Segoe UI Emoji",
"Segoe UI Symbol";

from jekyll-text-theme.

kitian616 avatar kitian616 commented on July 23, 2024 1
  • fonts is a very complex thing, quite hard to get a font families that compatible for all the language, I think the most compatible way is just use the Latin fonts.

  • I don't think it's necessary to make a fonts configurable in the _config.yml, You can just change the font in the _sass/common/_variables.scss.

  • I 'll change the fonts in the latter edition.

from jekyll-text-theme.

maddovr avatar maddovr commented on July 23, 2024

That's also the same with icons(how are the various formats supported btw?), theme continues to use its own assets folder instead of jekyll site one.

from jekyll-text-theme.

HenryQW avatar HenryQW commented on July 23, 2024

Did you add discord in _config.yml under author section?

author:
  name: potato
    discord:  blah

assets folder is meant to be used for resources, when Jekyll generates your site it moves every dependency into assets

from jekyll-text-theme.

kitian616 avatar kitian616 commented on July 23, 2024
  • It's base on Jekyll's default theme.

  • Did follow-me.html and follow-me.sass goes well? I don't know what link you are adding. you can modify site's nav bar links by nav_lists in _config.yml.

  • Icons however, it 's a little complex. you need change favicon.ico in the project root and the images in the assets/images/logo.

  • The footer use author.name in the _config.yml as your name. if you want use your own name, just change it to your own name.

from jekyll-text-theme.

maddovr avatar maddovr commented on July 23, 2024

A few updates:

  • Tried with a classical theme install(no gem theme), adding discord button works perfectly, I only modified follow-me.html, _follow-me.scss and _default.scss, yet jekyll basically asks for all the _sass and assets folders to be copied into the site path, which nullifies the gem advantage.

  • Replaced logo.svg, generated all icons with artwork and replaced favicon.ico, but two things happen:

  • Title logo remains unchanged
  • Favicon is extremely small in browser no matter what resolution favicon I put in the root folder. And ofc special favicons(apple touch, msbrowserconfig etc do not work). What step am I missing?

The footer uses the title instead of site.author.name and changing it from gem theme doesn't work for some reason, works flawlessly in normal theme install.

from jekyll-text-theme.

maddovr avatar maddovr commented on July 23, 2024

An update:

  • Decided to drop the gem-based theme, since it was basically a pain, went with the normal one;
  • Got favicons to work, however Microsoft edge doesn't(yet to test android and safari)
  • I don't know why, but now I've got a weird space when rendering the posts after each typography sign: https://abload.de/img/2018-03-01-13-05-locavrqr0.png what's causing it?

from jekyll-text-theme.

HenryQW avatar HenryQW commented on July 23, 2024

That’s the font family issue. The primary font is designed for non-western languages like Chinese and Korean, where all characters are full-width.

Eg, is a full-width comma ,

from jekyll-text-theme.

maddovr avatar maddovr commented on July 23, 2024

Actually in the gem based theme this weird space isn't present, and the same can be said for the demo. I thought it was a renderer(kramdown) error, but no idea where its configuration is.

from jekyll-text-theme.

HenryQW avatar HenryQW commented on July 23, 2024

I just manually replaced the font family in wherever-it-is.scss

from jekyll-text-theme.

kitian616 avatar kitian616 commented on July 23, 2024

Did Android or Safari also have that space?
I don't have a Windows environment at the moment, so I have to install one to see what's it going on.

from jekyll-text-theme.

maddovr avatar maddovr commented on July 23, 2024

Oddly enough, safari for iOS(11.2.6) displays correctly and the same for chrome on iOS. Also works for android 7.0 chrome. However on desktop it doesn't display correctly, Suggestions?

from jekyll-text-theme.

maddovr avatar maddovr commented on July 23, 2024

It works, thank you!

from jekyll-text-theme.

willguxy avatar willguxy commented on July 23, 2024

@WangQiru I understand that you mentioned we can change fonts in the .scss file. I still have two questions regarding this issue

  • Are there font families that render well on most if not all situations? Maybe it's hard to find something similar but more compatible, so just wondering.

  • Additionally, can we make fonts configurable in the _config.yml?

from jekyll-text-theme.

willguxy avatar willguxy commented on July 23, 2024

And by the way, both latest Chrome on Windows 7 and Chromium (default ppa) on Ubuntu 16.04 have this font issue.

from jekyll-text-theme.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.