Code Monkey home page Code Monkey logo

Comments (5)

sangelovic avatar sangelovic commented on August 18, 2024

Hello, how can I reproduce the scenario you are describing? I created a quick test case for that in my integration tests, but the signal gets delivered to all proxies.

from sdbus-cpp.

olta avatar olta commented on August 18, 2024

Hello - I think you need to create two proxies sharing a connection in order to reproduce the issue. I have tried to add a corresponding integration test, but that didn't trigger the problem as each TestingProxy uses its own connection.
Does that help in any way?

from sdbus-cpp.

olta avatar olta commented on August 18, 2024

I've managed to come up with a test triggering the problem:

commit 8da7bdeac35d3469ac80fd5c47fead0ad3f921fa (HEAD -> dev)
Author: Oliver Tappe <[email protected]>
Date:   Wed Mar 25 10:08:36 2020 +0100

    Add test for emitting a signal to multiple proxies on same connection.

diff --git a/tests/integrationtests/AdaptorAndProxy_test.cpp b/tests/integrationtests/AdaptorAndProxy_test.cpp
index 096d90f..7a5df37 100644
--- a/tests/integrationtests/AdaptorAndProxy_test.cpp
+++ b/tests/integrationtests/AdaptorAndProxy_test.cpp
@@ -473,6 +473,18 @@ TEST_F(SdbusTestObject, EmitsSimpleSignalSuccesfully)
     ASSERT_TRUE(waitUntil(m_proxy->m_gotSimpleSignal));
 }
 
+TEST_F(SdbusTestObject, EmitsSimpleSignalToMultipleProxiesSuccesfully)
+{
+    auto proxy1 = std::make_unique<TestingProxy>(*s_connection, INTERFACE_NAME, OBJECT_PATH);
+    auto proxy2 = std::make_unique<TestingProxy>(*s_connection, INTERFACE_NAME, OBJECT_PATH);
+
+    m_adaptor->emitSimpleSignal();
+
+    ASSERT_TRUE(waitUntil(m_proxy->m_gotSimpleSignal));
+    ASSERT_TRUE(waitUntil(proxy1->m_gotSimpleSignal));
+    ASSERT_TRUE(waitUntil(proxy2->m_gotSimpleSignal));
+}
+
 TEST_F(SdbusTestObject, EmitsSignalWithMapSuccesfully)
 {
     m_adaptor->emitSignalWithMap({{0, "zero"}, {1, "one"}});
diff --git a/tests/integrationtests/TestingProxy.h b/tests/integrationtests/TestingProxy.h
index 027af00..c4ea3e0 100644
--- a/tests/integrationtests/TestingProxy.h
+++ b/tests/integrationtests/TestingProxy.h
@@ -43,6 +43,12 @@ public:
         registerProxy();
     }
 
+    TestingProxy(sdbus::IConnection& connection, std::string destination, std::string objectPath)
+        : ProxyInterfaces(connection, std::move(destination), std::move(objectPath))
+    {
+        registerProxy();
+    }
+
     ~TestingProxy()
     {
         unregisterProxy();
l```

from sdbus-cpp.

sangelovic avatar sangelovic commented on August 18, 2024

I just came up with the same test case myself, having realized I first had proxies where each had its own connection :) Cool.

So you are right, the signal callback return value prohibits sd-bus from invoking other callbacks. I was not aware of that subtle difference.

Do you want to create a pull request with the changes you've proposed (including the new test case and additional TestingProxy constructor)?

from sdbus-cpp.

olta avatar olta commented on August 18, 2024

Done.

from sdbus-cpp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.