Comments (5)
UPower_proxy(sdbus::IProxy& proxy)
: proxy_(&proxy)
{
proxy_->uponSignal("DeviceAdded").onInterface(INTERFACE_NAME).call([this](const sdbus::ObjectPath& device){
this->onDeviceAdded(device);
});
proxy_->uponSignal("DeviceRemoved").onInterface(INTERFACE_NAME).call([this](const sdbus::ObjectPath& device){
this->onDeviceRemoved(device);
});
}
for example if i generate this proxy based on Upower specification that gets notificed when a device is plugged in, the lambda in the constructor makes a copy of this
, if i move this no longer works, kaput
my solution was to wrap my proxy in a unique_ptr, so i move the ptr, not the proxy itself.
from sdbus-cpp.
Thanks for reporting, yes, this is a bug. Generated adaptor and proxy classes cannot be moveable. Your solution with unique_ptr
is the recommended solution in case move support is needed (e.g. when the proxy or adaptor instances are stored in a container).
from sdbus-cpp.
The fix will go into the soon-to-be-release v2.0
.
from sdbus-cpp.
Thanks for the quick response @sangelovic,
It could still be possible to support moving by unregistering and re-registering, but not sure if that's worth the hassle
from sdbus-cpp.
@17steen Yes exactly, that would not be worth the hassle.
One problem could be that there is a thin time window where e.g. object's vtable is not registered. What if a D-Bus call comes just within that window? It would fail on nonexisting object, while that object is actually existing, just that it's being moved.
Or in case of a proxy, it would not listen to signals for that short time, but what if an (important) signal comes just in that window and it is not caught..?
This would thus be a fragile, error-prone solution opening up more problems than fixing.
from sdbus-cpp.
Related Issues (20)
- Support for creating tcp connections via sd_bus_set_address or sd_bus_set_fd HOT 2
- pkgconfig fails to resolve dependencies
- Tests installation path should respect install prefix
- Allow moving ProxyInterfaces HOT 2
- Error when implementing ObjectManager on System Bus Connection
- Sporadic missed NameAcquired signal if requestName called after enterEventLoopAsync HOT 2
- doesn't notice signal without method call HOT 7
- Serialization of maps into structs and vice versa
- Manually configuring choice of sd-bus implementation library HOT 4
- [org.freedesktop.DBus.Error.ServiceUnknown] The name com.example.test was not provided by any .service files HOT 5
- why: uncaught exception of type sdbus::Error ([org.freedesktop.DBus.Error.FileNotFound] Failed to open bus (No such file or directory)) HOT 1
- Crash when running a connection event loop HOT 2
- How to do IPC between two process by sdbus::createServerBus and sdbus::createDirectBusConnection
- Allow arbitrary structs in an sdbus interface HOT 4
- Support for serializing `std::variant<>` types HOT 2
- Can't receive signals by ObjectProxy at client side (but see this signals at dbus-monitor) HOT 2
- Ambiguous Template Instantiation when trying to use enum class with sdbus-cpp HOT 3
- What minimum version of systemd is actually required for v2.0.0?
- I'm not getting a signal HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sdbus-cpp.