kiranali / prj-rev-bwfs-dasmoto Goto Github PK

Satisfactory 👍

You've successfully reproduced the website according to the design mock. You've demonstrated a solid understanding of using HTML to markup your page's content and structure and of using CSS to apply fundamental styles. Nice job making strategic use of div tags, classes and IDs, and indentation to organize your HTML and CSS and make it easier to read and maintain.

Avoid unnecessary repetition and complexity in your CSS by applying shared styles with more general selectors.

https://github.com/kiranali/prj-rev-bwfs-dasmoto/blob/master/DasmotosArtShop/index.html#L13

Nice job including your website's assets (in this case images) in your project and provide a relative file path to them in your img tags. 👍

It's always better to provide static assets up front instead of depending on external URLs that could fail or otherwise become unavailable.

https://github.com/kiranali/prj-rev-bwfs-dasmoto/blob/master/DasmotosArtShop/index.html#L11-L19

Excellent job using div tags to divide your page into logical sections like the three equivalent product sections and the header section.

Even better giving the same class name to each div tag, since each "product" section is mostly styled the same way and can be styled as a group, and giving a different ID to each h2 tag, since each of these headings needs to be selected and styled individually.

Nice job using indentation when an element is nested inside of another element but consider leaving a blank line between each major section to improve readability.

⭐️

https://github.com/kiranali/prj-rev-bwfs-dasmoto/blob/master/DasmotosArtShop/resources/css/style.css#L1-L22

Consider using the universal selector * instead of listing out every single tag that needs the default font.

* {
  font-family: Helvetica;
}

https://github.com/kiranali/prj-rev-bwfs-dasmoto/blob/master/DasmotosArtShop/index.html#L17

Nice job using a proper inline tag like span to write your price information and giving each span tag the same class, like "price", which actually describes the content well. 👍

Using the same class allows you to easily select all of the span tags related to pricing and will prevent bugs in the future.

https://github.com/kiranali/prj-rev-bwfs-dasmoto/blob/master/DasmotosArtShop/index.html#L3-L7

Nice job providing your web page a title and providing a relative file path to your stylesheet instead of an absolute one. 👍

https://github.com/kiranali/prj-rev-bwfs-dasmoto/blob/master/DasmotosArtShop/index.html#L13

Nice job giving all of your img tags an alt attribute with a value that adequately describes the image, just in case your website is not able to load it. 👍

Doing so will help improve the accessibility of your website, which might be accessed by visually impaired users on e-readers or other devices that might deliberately neglect images-- as well as any other time that your website is just unable to render images.