kiqstyle / menusearch Goto Github PK

What steps will reproduce the problem?
1.When a user you would search for a recipe with some parameters empty. The 
RecipeSearch logic doesn't correctly set the parameters correctly for those 
parameters that are empty. Instead of setting those parameters as just null it 
is just throwing it back as "".  

Also, when one types in allergy or cuisine.. Recipesearch logic has to make 
sure it formats those things typed in correctly so yummly can read it to give 
the user the correct recipes. 


What is the expected output? What do you see instead?

So instead of having allergy = null, its would be equal to "".  

When someone types peanut into allergies its comes out as peanut but Yummly 
needs to be read 390^Peanuts

Correct formatting and what the Yummly api can take in for Cuisine and allergy 
can be found in Yummly Documentation 

A SQL Exception, complaining about incorrect SQL syntax, is being generated in 
this method. The problem is likely in the calling method. 

The method buries any exceptions that are thrown without a trace.

Instead of simply returning null, it should do this

catch (....)
 {
   System.err.println("exception thown in MenuSearcher.searchMenuDB, returning null " + ex)
   return null;
}

Really, this should be logged rather than output to standard error, but it is 
too late to do logging.

Please do this ASAP and commit.


Please use labels and text to provide additional information.

What steps will reproduce the problem?
1.
2.
3.

What is the expected output? What do you see instead?


Please use labels and text to provide additional information.

Everytime i click search on the SearchMenuPanel I get an error. It says there 
was a problem with the value entered for the year.

I try searching with the sponser as "Canada" and varying years. The stack trace 
always says error with year field " 1845" but I've never put 1845 in the search.

Every time menuSearchjFrame1 is run an error box pops up saying "Error! -- No 
menus returned for that search!"  The code that checks and creates this error 
message is from MenuResultsPage.

Two scenarios have been happening:

You click okay and the the program continues to run normally (happens with my 
computer)

OR

It crashes Netbeans and you have to forcefully quit and restart(happens with 
Kenny's computer)